chore: sync the wip-cst branch with the main branch #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status update: over the weekend I tried rebasing against ballista-compute/sqlparser-rs's main branch and (by no fault but my own) managed to produce the same unit-test results. I'm going to take a break from working on this branch and play around with Rowan more so that I can contribute to the AST-design question. |
That's expected, the difference is now you should be able to identify the commit introducing the failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests seem to pass on my machine.I've got at least one failing unit test when running
cargo test --all-featuresthat I could use help debugging. Nonetheless, I hope my work merging main into this branch will prove useful.