Skip to content

Clean up #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Clean up #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e1cb448
Adds reviewdog process
Feb 20, 2020
0d6f8cd
Test commit with a warnable offence for ReviewDog
Feb 20, 2020
cef3153
Revert "Test commit with a warnable offence for ReviewDog"
Feb 20, 2020
fbe073f
Adds Microsoft analysers
Feb 20, 2020
77a89d7
Moves reviewdog action to the right folder
Feb 20, 2020
91e63fe
Fixes reviewdog action indentation
Feb 20, 2020
c075205
Points the reviewdog action at master
Feb 20, 2020
9baadb0
Fixes a warning caused by an out-dated moq version
Feb 20, 2020
479317c
Adds an issue ReviewDog should catch
Feb 20, 2020
f7314d8
Misspell should catch this
Feb 20, 2020
a8e88a6
Adds more analyzers
Feb 20, 2020
17b3c7c
Removes reviewdog, updates dotnetcore to do better build logs
Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dotnetcore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ jobs:
with:
dotnet-version: 3.1.100
- name: Build with dotnet
run: dotnet build --configuration Release
run: dotnet build --configuration Release -v detailed -clp:NoSummary --nologo
- name: Run tests
run: dotnet test
4 changes: 3 additions & 1 deletion ControlStrings/ControlStringFinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ public IEnumerable<ControlString> FindAllControlStrings(string input)
throw new ArgumentNullException(nameof(input));
}

// Yield return methods doesn't throw any exceptions until you try to access the results
var a = true;

// Yield retrn methods doesn't throw any exceptions until you try to access the results
// This could happen at any time, including far away from when the error was caused
// So we pass error handle normally here and contain the yield return in its own bubble
return FindAllControlStringsEnumeratorInternal(input);
Expand Down
8 changes: 8 additions & 0 deletions ControlStrings/ControlStrings.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,12 @@
<AssemblyVersion>0.2.0.0</AssemblyVersion>
<FileVersion>0.2.0.0</FileVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="2.10.0" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="2.10.0" />
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>
</Project>
1 change: 1 addition & 0 deletions Unit Tests/UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<PackageReference Include="AutoFixture" Version="4.11.0" />
<PackageReference Include="AutoFixture.AutoMoq" Version="4.11.0" />
<PackageReference Include="AutoFixture.NUnit3" Version="4.11.0" />
<PackageReference Include="Moq" Version="4.13.1" />
<PackageReference Include="nunit" Version="3.12.0" />
<PackageReference Include="NUnit3TestAdapter" Version="3.16.1">
<PrivateAssets>all</PrivateAssets>
Expand Down