minor bug fix for single series, no covariate prediction

nicholasjclark · Feb 1, 2024 · 3620da0 · 3620da0
1 parent 30524cd
commit 3620da0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/R/evaluate_mvgams.R b/R/evaluate_mvgams.R
@@ -664,10 +664,12 @@ drps_score <- function(truth, fc, interval_width = 0.9,
   if(log){
     truth <- log(truth + 0.001)
     fc <- log(fc + 0.001)
+    nsum <- max(c(truth, fc), na.rm = TRUE) + 5
+  } else {
+    nsum <- max(c(truth,
+                  quantile(fc, probs = 0.99)), na.rm = TRUE) + 1000
   }
 
-  #nsum <- 1000
-  nsum <- max(c(truth, fc), na.rm = TRUE) + 1000
   Fy = ecdf(fc)
   ysum <- 0:nsum
   indicator <- ifelse(ysum - truth >= 0, 1, 0)

diff --git a/R/forecast.mvgam.R b/R/forecast.mvgam.R
@@ -811,7 +811,7 @@ forecast_draws = function(object,
       }
 
       # Bind the last 3 linpred rows with the forecast linpred rows
-      Xp_trend <- rbind(Xp_trend_last[linpred_order, ],
+      Xp_trend <- rbind(Xp_trend_last[linpred_order, , drop = FALSE],
                         Xp_trend)
       attr(Xp_trend, 'model.offset') <- full_offset
     }

diff --git a/src/mvgam.dll b/src/mvgam.dll