Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed original gist comments? #10

Closed
eyecatchup opened this issue Mar 14, 2019 · 2 comments
Closed

Embed original gist comments? #10

eyecatchup opened this issue Mar 14, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@eyecatchup
Copy link
Member

eyecatchup commented Mar 14, 2019

This issue is to track discussion whether to render the comments on the original gist or not.

You can see the current implementation here: https://nicegist.github.io/84aec347c6a1b90890dad8953d7e8c67#gist-comments

The comment section is only shown for gists that have received comments. (Compare the link above to this Nicegist without comments)

What I like about it is, that you can easily link to comments (since I create unique anchor links for each comment). See: https://nicegist.github.io/84aec347c6a1b90890dad8953d7e8c67#comment-1876170

Let me know what you think. I'm still not sure if I should keep it or if its too distracting (because, ultimately, the idea of Nicegist is to offer a clean representation for gists).

@eyecatchup eyecatchup changed the title Embded original gist comments Embed original gist comments Mar 14, 2019
@eyecatchup eyecatchup self-assigned this Mar 14, 2019
@eyecatchup eyecatchup added enhancement New feature or request question Further information is requested labels Mar 14, 2019
@eyecatchup eyecatchup changed the title Embed original gist comments Embed original gist comments? Mar 14, 2019
@fuzzy76
Copy link
Contributor

fuzzy76 commented Mar 14, 2019

Hmm... I'm torn. But that sort of also means I don't have a strong opinion either way. :) But design-wise I think they look nice.

@eyecatchup eyecatchup pinned this issue Mar 14, 2019
@eyecatchup
Copy link
Member Author

Closing, since it's not an open issue. Further discussion welcome. Pinned this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants