Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct link to the source gist #8

Closed
fuzzy76 opened this issue Mar 14, 2019 · 5 comments
Closed

Direct link to the source gist #8

fuzzy76 opened this issue Mar 14, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@fuzzy76
Copy link
Contributor

fuzzy76 commented Mar 14, 2019

It would be nice if there was a link to the original gist. Perhaps in the footer?

@eyecatchup
Copy link
Member

I've just added post metadata to the header. I guess that's the best place to add also a link to the source gist, right?

Bildschirmfoto 2019-03-14 um 11 01 29

--

Offtopic: I'm thinking about rendering comments, too. What do you think about it? Would that be helpful or would it rather clutter the Nicegist?

@eyecatchup eyecatchup self-assigned this Mar 14, 2019
@fuzzy76
Copy link
Contributor Author

fuzzy76 commented Mar 14, 2019

Hmm... I'm a bit torn on that. Perhaps collapsible? And only when there actually are comments? Don't think any of my gists have comments.

@eyecatchup
Copy link
Member

Yes, only if the gist has comments, I'd add the comment section.

Here's an example of my local version. I'm using the same styles as the mobile gist version. I actualy like it. You can easily link to comments as well (since I'm generating comment anchor links) like so nicegist.github.io/12345#comment-12345

127 0 0 1_3131__id=dab5cf7977008e504213(iPhone 6_7_8)

@eyecatchup
Copy link
Member

Desktop style:
Bildschirmfoto 2019-03-14 um 12 19 46

@eyecatchup
Copy link
Member

@fuzzy76 Closing this one, because direct link to source gist is live (link is on the pub date timestamp). Moved the discussion about comments to #10. Would be thankful for further feedback. :)

@eyecatchup eyecatchup added the enhancement New feature or request label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants