spec cleanup

lean on some rspec conventions / helpers to simplify our specs.  this `.rspec` automatically loads `spec_helper.rb` before any test is run, so we no longer need to explicitly require it everywhere

.rspec

@@ -0,0 +1 @@
+--require spec_helper

spec/flipper/actor_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Actor do
   it 'initializes with and knows flipper_id' do
     actor = described_class.new("User;235")

spec/flipper/adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Adapter do
   let(:source_flipper) { build_flipper }
   let(:destination_flipper) { build_flipper }

spec/flipper/adapters/active_record_spec.rb

@@ -1,6 +1,4 @@
-require 'helper'
 require 'flipper/adapters/active_record'
-require 'flipper/spec/shared_adapter_specs'
 
 # Turn off migration logging for specs
 ActiveRecord::Migration.verbose = false

spec/flipper/adapters/active_support_cache_store_spec.rb

@@ -1,9 +1,7 @@
-require 'helper'
 require 'active_support/cache'
 require 'active_support/cache/dalli_store'
 require 'flipper/adapters/operation_logger'
 require 'flipper/adapters/active_support_cache_store'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
   let(:memory_adapter) do

spec/flipper/adapters/dalli_spec.rb

@@ -1,7 +1,5 @@
-require 'helper'
 require 'flipper/adapters/operation_logger'
 require 'flipper/adapters/dalli'
-require 'flipper/spec/shared_adapter_specs'
 require 'logger'
 
 RSpec.describe Flipper::Adapters::Dalli do

spec/flipper/adapters/dual_write_spec.rb

@@ -1,7 +1,5 @@
-require 'helper'
 require 'flipper/adapters/dual_write'
 require 'flipper/adapters/operation_logger'
-require 'flipper/spec/shared_adapter_specs'
 require 'active_support/notifications'
 
 RSpec.describe Flipper::Adapters::DualWrite do

spec/flipper/adapters/http_spec.rb

@@ -1,7 +1,5 @@
-require 'helper'
 require 'flipper/adapters/http'
 require 'flipper/adapters/pstore'
-require 'flipper/spec/shared_adapter_specs'
 require 'rack/handler/webrick'
 
 FLIPPER_SPEC_API_PORT = ENV.fetch('FLIPPER_SPEC_API_PORT', 9001).to_i

spec/flipper/adapters/instrumented_spec.rb

@@ -1,7 +1,5 @@
-require 'helper'
 require 'flipper/adapters/instrumented'
 require 'flipper/instrumenters/memory'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::Instrumented do
   let(:instrumenter) { Flipper::Instrumenters::Memory.new }

spec/flipper/adapters/memoizable_spec.rb

@@ -1,7 +1,5 @@
-require 'helper'
 require 'flipper/adapters/memoizable'
 require 'flipper/adapters/operation_logger'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::Memoizable do
   let(:features_key) { described_class::FeaturesKey }

spec/flipper/adapters/memory_spec.rb

@@ -1,6 +1,3 @@
-require 'helper'
-require 'flipper/spec/shared_adapter_specs'
-
 RSpec.describe Flipper::Adapters::Memory do
   let(:source) { {} }
   subject { described_class.new(source) }

spec/flipper/adapters/moneta_spec.rb

@@ -1,6 +1,4 @@
-require 'helper'
 require 'flipper/adapters/moneta'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::Moneta do
   let(:moneta) { Moneta.new(:Memory) }

spec/flipper/adapters/mongo_spec.rb

@@ -1,6 +1,4 @@
-require 'helper'
 require 'flipper/adapters/mongo'
-require 'flipper/spec/shared_adapter_specs'
 
 Mongo::Logger.logger.level = Logger::INFO
 

spec/flipper/adapters/operation_logger_spec.rb

@@ -1,6 +1,4 @@
-require 'helper'
 require 'flipper/adapters/operation_logger'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::OperationLogger do
   let(:operations) { [] }

spec/flipper/adapters/pstore_spec.rb

@@ -1,6 +1,4 @@
-require 'helper'
 require 'flipper/adapters/pstore'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::PStore do
   subject do

spec/flipper/adapters/read_only_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/adapters/read_only'
 
 RSpec.describe Flipper::Adapters::ReadOnly do

spec/flipper/adapters/redis_cache_spec.rb

@@ -1,7 +1,5 @@
-require 'helper'
 require 'flipper/adapters/operation_logger'
 require 'flipper/adapters/redis_cache'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::RedisCache do
   let(:client) do

spec/flipper/adapters/redis_spec.rb

@@ -1,6 +1,4 @@
-require 'helper'
 require 'flipper/adapters/redis'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::Redis do
   let(:client) do

spec/flipper/adapters/rollout_spec.rb

@@ -1,8 +1,6 @@
-require 'helper'
 require 'redis'
 require 'rollout'
 require 'flipper/adapters/rollout'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::Rollout do
   let(:redis) { Redis.new }

spec/flipper/adapters/sequel_spec.rb

@@ -1,12 +1,10 @@
-require 'helper'
 require 'sequel'
 
 Sequel::Model.db = Sequel.sqlite(':memory:')
 Sequel.extension :migration, :core_extensions
 
 require 'flipper/adapters/sequel'
 require 'generators/flipper/templates/sequel_migration'
-require 'flipper/spec/shared_adapter_specs'
 
 RSpec.describe Flipper::Adapters::Sequel do
   subject do

spec/flipper/adapters/sync/feature_synchronizer_spec.rb

@@ -1,4 +1,3 @@
-require "helper"
 require "flipper/adapters/memory"
 require "flipper/adapters/operation_logger"
 require "flipper/adapters/sync/feature_synchronizer"

spec/flipper/adapters/sync/interval_synchronizer_spec.rb

@@ -1,4 +1,3 @@
-require "helper"
 require "flipper/adapters/sync/interval_synchronizer"
 
 RSpec.describe Flipper::Adapters::Sync::IntervalSynchronizer do

spec/flipper/adapters/sync/synchronizer_spec.rb

@@ -1,4 +1,3 @@
-require "helper"
 require "flipper/adapters/memory"
 require "flipper/instrumenters/memory"
 require "flipper/adapters/sync/synchronizer"

spec/flipper/adapters/sync_spec.rb

@@ -1,7 +1,5 @@
-require 'helper'
 require 'flipper/adapters/sync'
 require 'flipper/adapters/operation_logger'
-require 'flipper/spec/shared_adapter_specs'
 require 'active_support/notifications'
 
 RSpec.describe Flipper::Adapters::Sync do

spec/flipper/api/action_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::Action do
   let(:action_subclass) do
     Class.new(described_class) do

spec/flipper/api/json_params_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::JsonParams do
   let(:app) do
     app = lambda do |env|

spec/flipper/api/v1/actions/actors_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::ActorsGate do
   let(:app) { build_api(flipper) }
   let(:actor) { Flipper::Actor.new('1') }

spec/flipper/api/v1/actions/actors_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::Actors do
   let(:app) { build_api(flipper) }
   let(:actor) { Flipper::Actor.new('User123') }

spec/flipper/api/v1/actions/boolean_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::BooleanGate do
   let(:app) { build_api(flipper) }
 

spec/flipper/api/v1/actions/clear_feature_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::ClearFeature do
   let(:app) { build_api(flipper) }
 

spec/flipper/api/v1/actions/feature_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::Feature do
   let(:app) { build_api(flipper) }
   let(:feature) { build_feature }

spec/flipper/api/v1/actions/features_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::Features do
   let(:app) { build_api(flipper) }
   let(:feature) { build_feature }

spec/flipper/api/v1/actions/groups_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::GroupsGate do
   let(:app) { build_api(flipper) }
 

spec/flipper/api/v1/actions/percentage_of_actors_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::PercentageOfActorsGate do
   let(:app) { build_api(flipper) }
 

spec/flipper/api/v1/actions/percentage_of_time_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::PercentageOfTimeGate do
   let(:app) { build_api(flipper) }
 

spec/flipper/api_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api do
   describe 'Initializing middleware with flipper instance' do
     let(:app) { build_api(flipper) }

spec/flipper/cloud/configuration_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/cloud/configuration'
 require 'flipper/adapters/instrumented'
 

spec/flipper/cloud/dsl_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/cloud/configuration'
 require 'flipper/cloud/dsl'
 require 'flipper/adapters/operation_logger'

spec/flipper/cloud/engine_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'rails'
 require 'flipper/cloud'
 

spec/flipper/cloud/message_verifier_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/cloud/message_verifier'
 
 RSpec.describe Flipper::Cloud::MessageVerifier do

spec/flipper/cloud/middleware_spec.rb

@@ -1,5 +1,4 @@
 require 'securerandom'
-require 'helper'
 require 'flipper/cloud'
 require 'flipper/cloud/middleware'
 require 'flipper/adapters/operation_logger'

spec/flipper/cloud_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/cloud'
 require 'flipper/adapters/instrumented'
 require 'flipper/instrumenters/memory'

spec/flipper/configuration_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/configuration'
 
 RSpec.describe Flipper::Configuration do

spec/flipper/dsl_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/dsl'
 
 RSpec.describe Flipper::DSL do

spec/flipper/feature_check_context_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::FeatureCheckContext do
   let(:feature_name) { :new_profiles }
   let(:values) { Flipper::GateValues.new({}) }

spec/flipper/feature_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/feature'
 require 'flipper/instrumenters/memory'
 

spec/flipper/gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Gate do
   let(:feature_name) { :stats }
 

spec/flipper/gate_values_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/gate_values'
 
 RSpec.describe Flipper::GateValues do

spec/flipper/gates/actor_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Gates::Actor do
   let(:feature_name) { :search }
 

spec/flipper/gates/boolean_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Gates::Boolean do
   let(:feature_name) { :search }
 

spec/flipper/gates/group_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Gates::Group do
   let(:feature_name) { :search }
 

spec/flipper/gates/percentage_of_actors_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Gates::PercentageOfActors do
   let(:feature_name) { :search }
 

spec/flipper/gates/percentage_of_time_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Gates::PercentageOfTime do
   let(:feature_name) { :search }
 

spec/flipper/identifier_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/identifier'
 
 RSpec.describe Flipper::Identifier do

spec/flipper/instrumentation/log_subscriber_spec.rb

@@ -1,5 +1,4 @@
 require 'logger'
-require 'helper'
 require 'flipper/adapters/instrumented'
 require 'flipper/instrumentation/log_subscriber'
 

spec/flipper/instrumentation/statsd_subscriber_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/adapters/instrumented'
 require 'flipper/instrumentation/statsd'
 require 'statsd'

spec/flipper/instrumenters/memory_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/instrumenters/memory'
 
 RSpec.describe Flipper::Instrumenters::Memory do

spec/flipper/instrumenters/noop_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Instrumenters::Noop do
   describe '.instrument' do
     context 'with name' do

spec/flipper/middleware/memoizer_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'rack/test'
 require 'active_support/cache'
 require 'active_support/cache/dalli_store'
@@ -362,7 +361,6 @@ def get(uri, params = {}, env = {}, &block)
       end.to_app
     end
 
-
     context 'and unless option' do
       before do
         options[:unless] = ->(request) { request.path.start_with?("/assets") }

spec/flipper/middleware/setup_env_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Middleware::SetupEnv do
   context 'with flipper instance' do
     let(:app) do

spec/flipper/railtie_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'rails'
 require 'flipper/railtie'
 

spec/flipper/registry_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/registry'
 
 RSpec.describe Flipper::Registry do

spec/flipper/typecast_spec.rb

@@ -1,4 +1,3 @@
-require 'helper'
 require 'flipper/typecast'
 
 RSpec.describe Flipper::Typecast do