Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nifgen, niswitch metadata before 1.4.9 release #2083

Conversation

ni-jfitzger
Copy link
Collaborator

@ni-jfitzger ni-jfitzger commented Feb 24, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Update metadata to latest final export for nifgen, niswitch.

Handling this separately from the other metadata changes because of the messy .proto / pb2.py diffs.

  • The order of things changed in the .proto files and the resulting generated files
    • Not the first time this has happened and it hasn't caused problems in the past
    • If there were other changes, it's virtually impossible to tell

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (93b5c85) to head (5077da9).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2083   +/-   ##
=======================================
  Coverage   91.34%   91.35%           
=======================================
  Files          66       66           
  Lines       16292    16292           
=======================================
+ Hits        14882    14883    +1     
+ Misses       1410     1409    -1     
Flag Coverage Δ
codegenunittests 84.95% <ø> (ø)
nidcpowersystemtests 94.59% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 87.24% <ø> (ø)
nifgensystemtests 94.86% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b5c85...5077da9. Read the comment docs.

@ni-jfitzger ni-jfitzger merged commit 4d22c69 into ni:master Feb 24, 2025
35 checks passed
@ni-jfitzger ni-jfitzger deleted the update-metadata-for-1-4-9-release-noisy-changes branch February 24, 2025 23:05
@ni-jfitzger ni-jfitzger added this to the nimi-python 1.4.9 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants