Show environment banner on staging environments #2822
+134
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrobertlloyd
force-pushed
the
environment-banner
branch
from
9db29d1 to
9e7e218
Compare
thomasleese
force-pushed
the
environment-banner
branch
6 times, most recently
from
0fd22dd to
0e55959
Compare
|
Thanks for the spruce-up @thomasleese! |
thomasleese
reviewed
Jan 15, 2025
| end | ||
|
|
||
| def environment | ||
| ENV.fetch("SENTRY_ENVIRONMENT", "development") |
There was a problem hiding this comment.
Since this is the only place we're using this environment variable (other than Sentry itself) I thought it was okay to use it here, but if we start needing this in more places I suggest we have a HOSTING_ENVIRONMENT variable and configure Sentry to use that instead.
tvararu
approved these changes
Jan 15, 2025
thomasleese
force-pushed
the
environment-banner
branch
from
0e55959 to
721415f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styles and markup for an
AppHostingEnvironmentComponentthat renders a banner above the header on all staging environments, giving an environment’s name and assigned colour, default to staging/grey if this cannot be determined.HOSTING_ENVIRONMENT_NAMEvariable? If not, where can I get the named environment?Also deleted the custom styling for white tags as we don’t use that anymore.
Banners