-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(store): allow plain functions in withNgxsPlugin
#2255
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e1be45b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
e4fadcb
to
d3a03ae
Compare
commit: |
BundleMonFiles updated (2)
Unchanged files (4)
Total files change +610B +0.46% Groups updated (2)
Final result: ❌ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (4)
Unchanged files (5)
Total files change -144B -0.7% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (3)
Total files change +181B +0.09% Final result: ✅ View report in BundleMon website ➡️ |
d3a03ae
to
eca4f37
Compare
eca4f37
to
cd54dc4
Compare
We allow passing a plain function into `withNgxsPlugin`, as the plugin can be a simple function (not a class).
cd54dc4
to
e1be45b
Compare
Code Climate has analyzed commit e1be45b and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 93.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
We allow passing a plain function into
withNgxsPlugin
, as the plugin can be a simplefunction (not a class).