perf(store): replace instanceof Function with typeof

[arturovt]

typeof avoids prototype chain checks and type coercion, which is faster:

instanceof Function x 104,665,819 ops/sec ±4.90% (44 runs sampled)
typeof function x 169,867,932 ops/sec ±6.42% (55 runs sampled)

Btw fastest benchmarked checks were:

1.
const returnValueType = typeof returnValue;
returnValueType[0] === 'f'

2.
const F_CHAR_CODE = 102;
const returnValueType = typeof returnValue;
(returnValueType.charCodeAt(0) ^ F_CHAR_CODE) === 0;

3.
const F_CHAR_CODE = 102;
const returnValueType = typeof returnValue;
returnValueType.charCodeAt(0) === F_CHAR_CODE;

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e0e9245. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx run-many --target=lint --all --configuration=ci --base=remotes/origin/master --head=HEAD
• nx lint-types store
• nx run-many --target=test --all --configuration=ci --base=remotes/origin/master --head=HEAD
• nx run-many --target=build --all

---

Sent with 💌 from NxCloud.

[pkg-pr-new]

Open in Stackblitz

@ngxs/devtools-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/form-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/hmr-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/router-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/storage-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/store

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/websocket-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

commit: e0e9245

[bundlemon]

BundleMon

Files updated (1)

Status	Path	Size	Limits
✅	fesm2022/ngxs-store.mjs	102.5KB (+55B +0.05%)	103KB / +0.5%

Unchanged files (5)

Status	Path	Size	Limits
✅	fesm2022/ngxs-store-internals.mjs	11.64KB	13KB / +0.5%
✅	fesm2022/ngxs-store-internals-testing.mjs	6.83KB	7KB / +0.5%
✅	fesm2022/ngxs-store-operators.mjs	6.22KB	7KB / +0.5%
✅	fesm2022/ngxs-store-plugins.mjs	2.04KB	3KB / +0.5%
✅	fesm2022/ngxs-store-experimental.mjs	1.4KB	2KB / +0.5%

Total files change +55B +0.04%

Groups updated (2)

Status	Path	Size	Limits
✅	@ngxs/store(esm2022)[gzip] ./esm2022/**/*.mjs	224.61KB (+116B +0.05%)	+1%
✅	@ngxs/store(fesm2022)[gzip] ./fesm2022/*.mjs	31.25KB (+11B +0.03%)	+1%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[bundlemon]

BundleMon (NGXS Plugins)

Unchanged files (9)

Status	Path	Size	Limits
✅	Plugins(fesm2022)[gzip] storage-plugin/fesm2022/ngxs-storage-plugin.m js	4.15KB	+0.5%
✅	Plugins(fesm2022)[gzip] router-plugin/fesm2022/ngxs-router-plugin.mjs	3.2KB	+0.5%
✅	Plugins(fesm2022)[gzip] websocket-plugin/fesm2022/ngxs-websocket-plug in.mjs	2.64KB	+0.5%
✅	Plugins(fesm2022)[gzip] hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs	2.61KB	+0.5%
✅	Plugins(fesm2022)[gzip] form-plugin/fesm2022/ngxs-form-plugin.mjs	2.59KB	+0.5%
✅	Plugins(fesm2022)[gzip] devtools-plugin/fesm2022/ngxs-devtools-plugin .mjs	2.23KB	+0.5%
✅	Plugins(fesm2022)[gzip] logger-plugin/fesm2022/ngxs-logger-plugin.mjs	2.03KB	+0.5%
✅	Plugins(fesm2022)[gzip] storage-plugin/fesm2022/ngxs-storage-plugin-i nternals.mjs	875B	+0.5%
✅	Plugins(fesm2022)[gzip] router-plugin/fesm2022/ngxs-router-plugin-int ernals.mjs	411B	+0.5%

No change in files bundle size

Unchanged groups (1)

Status	Path	Size	Limits
✅	All Plugins(fesm2022)[gzip] ./-plugin/fesm2022/.mjs	20.71KB	+0.5%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[bundlemon]

BundleMon (Integration Projects)

Unchanged files (3)

Status	Path	Size	Limits
✅	Main bundles(Gzip) hello-world-ng18/dist-integration/browser/mai n-(hash).js	71.86KB	+1%
✅	Main bundles(Gzip) hello-world-ng17/dist-integration/main.(hash) .js	68.68KB	+1%
✅	Main bundles(Gzip) hello-world-ng16/dist-integration/main.(hash) .js	67.79KB	+1%

Total files change -15B -0.01%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history | Target branch size history

[markwhitfeld]

Nice perf tweak. You just need to update the changelog in this PR too.

[codeclimate]

Code Climate has analyzed commit e0e9245 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.4% (0.0% change).

View more on Code Climate.