perf(store): improve compliant prop getter #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d129f9b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
BundleMon (Integration Projects)Files updated (1)
Unchanged files (1)
Total files change +25B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
This commit enhances the `compliantPropGetter` function's implementation. The prop getter is heavily utilized in NGXS. I noticed that the function unnecessarily copies `paths`. It now returns a function that accepts an object as a parameter and attempts to select a property deeply. We've replaced the use of `reduce` with a single for-loop, making it simpler. Though it doesn't significantly impact size, there's only a minor difference in production bundle size. Regarding performance, I checked the `perf.link` service and got the following results: - Old compliant prop getter: 120,410 ops/s - New compliant prop getter: 220,480 ops/s I generated a deeply nested object and set my CPU slowdown to 6x. The new implementation is only 30% faster, but it's reasonable to have a slightly faster implementation if possible. At least it's not causing any negative impact.
arturovt
force-pushed
the
perf/prop-getter
branch
from
c700dfa to
d129f9b
Compare
|
Code Climate has analyzed commit d129f9b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.0% change). View more on Code Climate. |
rhutchison
approved these changes
Mar 13, 2024
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the
compliantPropGetterfunction's implementation. The prop getter is heavily utilized in NGXS. I noticed that the function unnecessarily copiespaths. It now returns a function that accepts an object as a parameter and attempts to select a property deeply. We've replaced the use ofreducewith a single for-loop, making it simpler. Though it doesn't significantly impact size, there's only a minor difference in production bundle size.Regarding performance, I checked the
perf.linkservice and got the following results:I generated a deeply nested object and set my CPU slowdown to 6x. The new implementation is only 30% faster, but it's reasonable to have a slightly faster implementation if possible. At least it's not causing any negative impact.