Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format files after upgrading to Nx 17 #2096

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Feb 5, 2024

No functional changes, only formatting. Making this change now because we didn't address formatting in the actual migration PR. This saves us from having to format on other subsequent changes incoming.

Copy link

nx-cloud bot commented Feb 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 000aec6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

bundlemon bot commented Feb 5, 2024

BundleMon (Integration Projects)

Files added (2)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
+67.4KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
+65.9KB +1%
Files removed (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng15/dist-integration/main.(hash)
.js
-63.35KB +1%

Total files change +69.96KB +110.44%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@arturovt arturovt merged commit a587e00 into master Feb 5, 2024
11 checks passed
@arturovt arturovt deleted the chore/formatting branch February 5, 2024 22:27
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants