-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: state, store and starter-kit schematics support a project option #2089
feat: state, store and starter-kit schematics support a project option #2089
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit baee261. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
BundleMon (Integration Projects)Files updated (1)
Total files change +34B +0.05% Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code Climate has analyzed commit baee261 and detected 14 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.5% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@profanis Great work!!!
The only thing missing is an update to the changelog.md
file describing these changes.
But, I'll merge without it so that you don't have to dismiss the existing reviews.
When we use the schematics to create
we can rely on the project type and have the spec files with either
provideStore()
orNgxsModule.forRoot()
if it's a standalone or not.Furthermore, if we have a mono-repo workspace we can provide the
project
where we want to have the schematic run.