Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: state, store and starter-kit schematics support a project option #2089

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

profanis
Copy link
Contributor

When we use the schematics to create

  • state
  • store
  • starter-kit

we can rely on the project type and have the spec files with either provideStore() or NgxsModule.forRoot() if it's a standalone or not.

Furthermore, if we have a mono-repo workspace we can provide the project where we want to have the schematic run.

Copy link

nx-cloud bot commented Dec 14, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit baee261. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

bundlemon bot commented Dec 14, 2023

BundleMon (Integration Projects)

Files updated (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng15/dist-integration/main.(hash)
.js
63.38KB (+34B +0.05%) +1%

Total files change +34B +0.05%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Member

@arturovt arturovt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profanis profanis requested a review from arturovt December 14, 2023 16:49
Copy link

codeclimate bot commented Dec 15, 2023

Code Climate has analyzed commit baee261 and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 14

The test coverage on the diff in this pull request is 96.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.4% (0.5% change).

View more on Code Climate.

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@profanis Great work!!!
The only thing missing is an update to the changelog.md file describing these changes.
But, I'll merge without it so that you don't have to dismiss the existing reviews.

@markwhitfeld markwhitfeld merged commit ce98589 into ngxs:master Dec 15, 2023
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants