ci(bundlemon): replace bundlesize with bundlemon #1865

rfprod · 2022-06-17T20:47:14Z

remove bundlesize dependency, config, scripts and github ci jobs;
add bundlemon dependency, config and github ci jobs;
regenerate yarn.lock after replacing project dependencies;
address TODOs https://github.com/ngxs/store/compare/master...rfprod:bundlemon?expand=1#diff-04af3c9c96028eebf4fa93d5c67e1fa08255fb7a3682f912ccd5bea1dff5ccd4R146-R154
- @markwhitfeld: create a bundlemon project https://app.bundlemon.dev/create-project;
- @markwhitfeld: save both values in the repository secrets that will be generated and printed in the UI after a project is created: BUNDLEMON_PROJECT_ID - this will be needed for reporting, BUNDLEMON_PROJECT_API_KEY - this one will not be used (its written in the docs that the API key is not required for public repos), but seems like it's worth at least saving the value. Docs ref: https://github.com/LironEr/bundlemon-github-actions#create-bundlemon-project
- @markwhitfeld: install bundlemon GitHub App https://github.com/apps/bundlemon to add GitHub integration. Docs ref: https://github.com/LironEr/bundlemon-github-actions#add-github-integration
- @rfprod: remove TODOs from the pr-validation workflow;

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[x] bundlesize was replaced with bundlemon

What is the current behavior?

Bundlesize is used to check bundle sizes.

Issue Number: #1764

What is the new behavior?

Bundlemon is used to check bundle sizes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

markwhitfeld · 2022-06-20T19:58:29Z

I'll set this up and test it tomorrow morning.

- [x] remove bundlesize dependency, config, scripts and github ci jobs; - [x] add bundlemon dependency, config and github ci jobs; - [x] regenerate yarn.lock after replacing project dependencies;

bundlemon · 2022-06-22T13:57:26Z

BundleMon

Files added (6)

Status	Path	Size	Limits
✅	fesm5/ngxs-store.js	+136.44KB	145KB / +0.5%
✅	fesm2015/ngxs-store.js	+117.47KB	125KB / +0.5%
✅	fesm5/ngxs-store-internals.js	+15.8KB	20KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	+14.84KB	20KB / +0.5%
✅	fesm5/ngxs-store-operators.js	+10.07KB	15KB / +0.5%
✅	fesm2015/ngxs-store-operators.js	+9.94KB	15KB / +0.5%

Total files change +304.56KB 0%

Groups added (6)

Status	Path	Size	Limits
✅	@ngxs/store(esm5)[gzip] _{./esm5/*/.js}	+187.14KB	+1%
✅	@ngxs/store(esm2015)[gzip] _{./esm2015/*/.js}	+180.67KB	+1%
✅	@ngxs/store(umd)[gzip] _{./bundles/*.umd.js}	+42.47KB	+1%
✅	@ngxs/store(fesm5)[gzip] _./fesm5/*.js	+31.85KB	+1%
✅	@ngxs/store(fesm2015)[gzip] _{./fesm2015/*.js}	+29.45KB	+1%
✅	@ngxs/store(umd.min)[gzip] _{./bundles/*.umd.min.js}	+13.98KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

bundlemon · 2022-06-22T13:57:29Z

BundleMon (NGXS Plugins)

Files added (28)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. js}	+7.69KB	+1%
✅	Plugins(umd)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.js}	+6.96KB	+1%
✅	Plugins(umd)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js}	+6.87KB	+1%
✅	Plugins(umd)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.js}	+6.49KB	+1%
✅	Plugins(umd)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.js}	+6.4KB	+1%
✅	Plugins(umd)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.js}	+5.91KB	+1%
✅	Plugins(umd)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. js}	+5.77KB	+1%
✅	Plugins(fesm5)[gzip] _{router-plugin/fesm5/ngxs-router-plugin.js}	+4.29KB	+1%
✅	Plugins(fesm2015)[gzip] _{router-plugin/fesm2015/ngxs-router-plugin.js}	+4.01KB	+1%
✅	Plugins(fesm5)[gzip] _{hmr-plugin/fesm5/ngxs-hmr-plugin.js}	+3.62KB	+1%
✅	Plugins(fesm5)[gzip] _{websocket-plugin/fesm5/ngxs-websocket-plugin. js}	+3.53KB	+1%
✅	Plugins(fesm2015)[gzip] _{hmr-plugin/fesm2015/ngxs-hmr-plugin.js}	+3.25KB	+1%
✅	Plugins(fesm5)[gzip] _{storage-plugin/fesm5/ngxs-storage-plugin.js}	+3.2KB	+1%
✅	Plugins(fesm2015)[gzip] _{websocket-plugin/fesm2015/ngxs-websocket-plug in.js}	+3.15KB	+1%
✅	Plugins(umd.min)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.min.js}	+3.1KB	+1%
✅	Plugins(fesm5)[gzip] _{form-plugin/fesm5/ngxs-form-plugin.js}	+3.04KB	+1%
✅	Plugins(fesm2015)[gzip] _{storage-plugin/fesm2015/ngxs-storage-plugin.j s}	+2.87KB	+1%
✅	Plugins(fesm2015)[gzip] _{form-plugin/fesm2015/ngxs-form-plugin.js}	+2.71KB	+1%
✅	Plugins(umd.min)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. min.js}	+2.7KB	+1%
✅	Plugins(fesm5)[gzip] _{devtools-plugin/fesm5/ngxs-devtools-plugin.js}	+2.58KB	+1%
✅	Plugins(fesm5)[gzip] _{logger-plugin/fesm5/ngxs-logger-plugin.js}	+2.48KB	+1%
✅	Plugins(umd.min)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.min. js}	+2.41KB	+1%
✅	Plugins(fesm2015)[gzip] _{devtools-plugin/fesm2015/ngxs-devtools-plugin .js}	+2.4KB	+1%
✅	Plugins(fesm2015)[gzip] _{logger-plugin/fesm2015/ngxs-logger-plugin.js}	+2.37KB	+1%
✅	Plugins(umd.min)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.min.js}	+2.18KB	+1%
✅	Plugins(umd.min)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.min.js}	+2.15KB	+1%
✅	Plugins(umd.min)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. min.js}	+1.95KB	+1%
✅	Plugins(umd.min)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.min.js}	+1.83KB	+1%

Total files change +105.92KB 0%

Groups added (6)

Status	Path	Size	Limits
✅	All Plugins(esm5)[gzip] _{./-plugin/esm5/**/.js}	+117.96KB	+1%
✅	All Plugins(esm2015)[gzip] _{./-plugin/esm2015/**/.js}	+112.65KB	+1%
✅	All Plugins(umd)[gzip] _{./-plugin/bundles/.umd.js}	+46.1KB	+1%
✅	All Plugins(fesm5)[gzip] _{./-plugin/fesm5/.js}	+22.75KB	+1%
✅	All Plugins(fesm2015)[gzip] _{./-plugin/fesm2015/.js}	+20.76KB	+1%
✅	All Plugins(umd.min)[gzip] _{./-plugin/bundles/.umd.min.js}	+16.32KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

bundlemon · 2022-06-22T13:57:32Z

BundleMon (Integration Projects)

Files added (4)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng11-ivy/dist-integration/main.(h ash).js}	+71.05KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng13-ivy/dist-integration/main.(h ash).js}	+69.76KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng12-ivy/dist-integration/main.(h ash).js}	+67.72KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng14-ivy/dist-integration/main.(h ash).js}	+65.53KB	+1%

Total files change +274.05KB 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

rfprod force-pushed the bundlemon branch 2 times, most recently from 997e018 to e643bb6 Compare June 18, 2022 17:00

arturovt linked an issue Jun 18, 2022 that may be closed by this pull request

[BUILD TOOLS]: Replace Bundlesize #1764

Closed

arturovt mentioned this pull request Jun 20, 2022

ci: remove packages from bundlesize and leave only production bundles #1862

Closed

ci(bundlemon): replace bundlesize with bundlemon

ee84747

- [x] remove bundlesize dependency, config, scripts and github ci jobs; - [x] add bundlemon dependency, config and github ci jobs; - [x] regenerate yarn.lock after replacing project dependencies;

rfprod force-pushed the bundlemon branch from e643bb6 to ee84747 Compare June 21, 2022 15:05

chore: clean up

301a4ec

markwhitfeld marked this pull request as ready for review June 22, 2022 08:11

markwhitfeld requested review from markwhitfeld, arturovt, kuncevic, Carniatto, poloagustin, joaqcid and splincode as code owners June 22, 2022 08:11

refactore: split and improve bundlemon config

a376df0

markwhitfeld approved these changes Jun 22, 2022

View reviewed changes

fix: add explicit BUNDLEMON_PROJECT_ID so that PRs can run the check

87fff3e

markwhitfeld merged commit 770aa34 into ngxs:master Jun 22, 2022

rfprod deleted the bundlemon branch June 22, 2022 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(bundlemon): replace bundlesize with bundlemon #1865

ci(bundlemon): replace bundlesize with bundlemon #1865

rfprod commented Jun 17, 2022 •

edited by markwhitfeld

Loading

markwhitfeld commented Jun 20, 2022

bundlemon bot commented Jun 22, 2022

bundlemon bot commented Jun 22, 2022

bundlemon bot commented Jun 22, 2022

ci(bundlemon): replace bundlesize with bundlemon #1865

ci(bundlemon): replace bundlesize with bundlemon #1865

Conversation

rfprod commented Jun 17, 2022 • edited by markwhitfeld Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

markwhitfeld commented Jun 20, 2022

bundlemon bot commented Jun 22, 2022

BundleMon

bundlemon bot commented Jun 22, 2022

BundleMon (NGXS Plugins)

bundlemon bot commented Jun 22, 2022

BundleMon (Integration Projects)

rfprod commented Jun 17, 2022 •

edited by markwhitfeld

Loading