WaveformArea: implemented secondary trigger level arrow. Fixes #658.

ngscopeclient · Dec 6, 2023 · 97592c3 · 97592c3
1 parent 7d7558f
commit 97592c3
Show file tree

Hide file tree

Showing 3 changed files with 88 additions and 6 deletions.
diff --git a/lib b/lib
diff --git a/src/ngscopeclient/WaveformArea.cpp b/src/ngscopeclient/WaveformArea.cpp
@@ -2576,13 +2576,41 @@ void WaveformArea::RenderTriggerLevelArrows(ImVec2 start, ImVec2 /*size*/)
 			}
 		}
 
-		//TODO: second level
+		//Second level
 		auto sl = dynamic_cast<TwoLevelTrigger*>(trig);
 		if(sl)
-			LogWarning("Two-level triggers not implemented\n");
+		{
+			//Draw the arrow
+			//If currently dragging, show at mouse position rather than actual hardware trigger level
+			level = sl->GetLowerBound();
+			y = YAxisUnitsToYPosition(level);
+			if( (m_dragState == DRAG_STATE_TRIGGER_SECONDARY_LEVEL) && (trig == m_triggerDuringDrag) )
+				y = mouse.y;
+			arrowtop = y - arrowsize/2;
+			arrowbot = y + arrowsize/2;
+			draw_list->AddTriangleFilled(
+				ImVec2(start.x, y), ImVec2(arrowright, arrowtop), ImVec2(arrowright, arrowbot), color);
+
+			//Check mouse position
+			//Use slightly expanded hitbox to make it easier to capture
+			caparrowtop = y - caparrowsize/2;
+			caparrowbot = y + caparrowsize/2;
+			if( (mouse.x >= start.x) && (mouse.x <= caparrowright) && (mouse.y >= caparrowtop) && (mouse.y <= caparrowbot) )
+			{
+				ImGui::SetMouseCursor(ImGuiMouseCursor_ResizeNS);
+				m_mouseOverTriggerArrow = true;
+
+				if(ImGui::IsMouseClicked(ImGuiMouseButton_Left))
+				{
+					LogTrace("Start dragging secondary trigger level\n");
+					m_dragState = DRAG_STATE_TRIGGER_SECONDARY_LEVEL;
+					m_triggerDuringDrag = trig;
+				}
+			}
+		}
 
 		//Handle dragging
-		if(m_dragState == DRAG_STATE_TRIGGER_LEVEL)
+		if( (m_dragState == DRAG_STATE_TRIGGER_LEVEL) || (m_dragState == DRAG_STATE_TRIGGER_SECONDARY_LEVEL) )
 			m_triggerLevelDuringDrag = YPositionToYAxisUnits(mouse.y);
 	}
 }
@@ -3354,8 +3382,61 @@ void WaveformArea::OnMouseUp()
 				Unit volts(Unit::UNIT_VOLTS);
 				LogTrace("End dragging trigger level (at %s)\n", volts.PrettyPrint(m_triggerLevelDuringDrag).c_str());
 
-				m_triggerDuringDrag->SetLevel(m_triggerLevelDuringDrag);
-				m_triggerDuringDrag->GetScope()->PushTrigger();
+				//If two-level trigger, make sure we have the levels in the right order
+				auto tlt = dynamic_cast<TwoLevelTrigger*>(m_triggerDuringDrag);
+				if(tlt)
+				{
+					//We're dragging the primary level, which should always be higher than the secondary
+					auto sec = tlt->GetLowerBound();
+					if(m_triggerLevelDuringDrag >= sec)
+					{
+						tlt->SetUpperBound(m_triggerLevelDuringDrag);
+						tlt->GetScope()->PushTrigger();
+					}
+
+					//But if we dragged past the secondary level, invert (otherwise we'll never trigger)
+					else
+					{
+						tlt->SetUpperBound(sec);
+						tlt->SetLowerBound(m_triggerLevelDuringDrag);
+						tlt->GetScope()->PushTrigger();
+					}
+				}
+
+				else
+				{
+					m_triggerDuringDrag->SetLevel(m_triggerLevelDuringDrag);
+					m_triggerDuringDrag->GetScope()->PushTrigger();
+				}
+			}
+			break;
+
+		case DRAG_STATE_TRIGGER_SECONDARY_LEVEL:
+			{
+				Unit volts(Unit::UNIT_VOLTS);
+				LogTrace("End dragging secondary trigger level (at %s)\n",
+					volts.PrettyPrint(m_triggerLevelDuringDrag).c_str());
+
+				//If two-level trigger, make sure we have the levels in the right order
+				auto tlt = dynamic_cast<TwoLevelTrigger*>(m_triggerDuringDrag);
+				if(tlt)
+				{
+					//We're dragging the secondary level, which should always be lower than the secondary
+					auto prim = tlt->GetUpperBound();
+					if(m_triggerLevelDuringDrag < prim)
+					{
+						tlt->SetLowerBound(m_triggerLevelDuringDrag);
+						tlt->GetScope()->PushTrigger();
+					}
+
+					//But if we dragged past the secondary level, invert (otherwise we'll never trigger)
+					else
+					{
+						tlt->SetUpperBound(m_triggerLevelDuringDrag);
+						tlt->SetLowerBound(prim);
+						tlt->GetScope()->PushTrigger();
+					}
+				}
 			}
 			break;
 

diff --git a/src/ngscopeclient/WaveformArea.h b/src/ngscopeclient/WaveformArea.h
@@ -566,6 +566,7 @@ class WaveformArea
 		DRAG_STATE_CHANNEL_LAST,
 		DRAG_STATE_Y_AXIS,
 		DRAG_STATE_TRIGGER_LEVEL,
+		DRAG_STATE_TRIGGER_SECONDARY_LEVEL,
 		DRAG_STATE_BER_LEVEL,
 		DRAG_STATE_BER_BOTH,
 		DRAG_STATE_PEAK_MARKER