Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick a reasonable fallback wrap width when GetConsoleScreenBufferInfo() fails #10

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

attie
Copy link

@attie attie commented Nov 14, 2020

This PR resolves the initial problem raised in #9, and allows the output to be legible when GetConsoleScreenBufferInfo() fails.

This PR does not resolve the underlying issue.

Output with patch applied:

Attie@pongo MINGW64 /z/proj/scopehal/scopehal-apps/build
$ glscopeclient.exe scope:agilent:lan:scope.attie.co.uk:5025
GetConsoleScreenBufferInfo() failed (6);
Warning: glscopeclient works best with the OMP_WAI
T_POLICY environment variable set to PASSIVE
Warning: No Rx timeout: No error
Warning: No Tx timeout: No error
    Warning: Unknown trigger type "DEL"
    Warning: Unknown trigger type "DEL"
    Warning: Unknown trigger type "DEL"
    Warning: Unknown trigger type "DEL"
Warning: Unknown trigger type "DEL"
    Warning: Unknown trigger type "DEL"
[...]

Error 6 is ERROR_INVALID_HANDLE.

@azonenberg azonenberg merged commit 232e03e into ngscopeclient:master Nov 14, 2020
@attie attie deleted the windows-wrap branch December 4, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants