-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signals): Remove the protection for state mutation in dev mode #4686
fix(signals): Remove the protection for state mutation in dev mode #4686
Conversation
Applying `Object.freeze` on the state caused too many issues with edge cases, where mutable changes are necessary. Therefore, this feature is removed.
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be useful to also mention the revert in the migration guide?
@timdeschryver I'd just remove the whole section. Devs should always install the latest v19? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rainerhahnekamp
Applying
Object.freeze
on the state caused too many issues with edge cases, where mutable changes are necessary.Therefore, this feature is removed.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Closes #4683
What is the new behavior?
Does this PR introduce a breaking change?