-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Update previous API gateway tutorials to bring into parity (v2) #1238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joelhans
wants to merge
8
commits into
main
Choose a base branch
from
api-gateway-parity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nijikokun
reviewed
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #1192 in favor of this PR, as I took a completely different take on how to organize them after learning a lot from the multicloud one.
This looks like a ton of change, but it's a lot of copy-paste to makes sure that all three API gateway specific tutorials follow the same pattern of implementation (as lead by the multicloud tutorial), use the same demo services, and, for the K8s ones, use the new Operator features like
AgentEndpoint
resources, instead of Gateway API (which requires way more complicated YAML configs).@shubcodes You might be helpful with your experience in these kinds of setups.
@Alice-Lilith Would love to make sure I'm representing the K8s features properly—I've tested these to work, but I'm sure there are even better ways to present the workflows and make it super smooth.