[pull] dev from KelvinTegelaar:dev - #29
Merged
Merged
Conversation
Added partner tenant information panel to CippTenantModeDeploy, showing organization, user, and partner type details. Updated CIPPM365OAuthButton to improve button icon logic and validation. Extended CippTranslations with partner type labels for better UI clarity.
Eliminated the 'GDAP Details' and 'Permission Details' Typography headers from CippGDAPResults and CippPermissionResults components to streamline the UI and reduce unnecessary repetition.
Upgraded react-dom from 19.1.1 to 19.2.3 and updated scheduler dependency accordingly. Also removed an unused import of React from CippTenantTable.jsx.
Adds a refresh button for partner tenant info, updates guidance text to clarify partner tenant connection requirements, and improves loading and error states. Also disables connecting separate tenants until a partner tenant is connected, enhancing user flow and preventing misconfiguration.
Implements retry mechanism with exponential backoff for the AADSTS650051 error (service principal already exists) during the token exchange process in CIPPM365OAuthButton. This improves reliability when encountering transient Azure AD errors.
Moved the CippApiResults for updateRefreshToken and addTenant to better align with their relevant sections in the CippTenantModeDeploy component. This improves the logical grouping and clarity of API result displays.
Refactors appId refetching to only occur when applicationId is not already present, reducing unnecessary network calls. Adds retry logic with exponential backoff for the AADSTS650051 error during MSAL authentication, improving user experience when service principal consent issues occur.
Set relatedQueryKeys for ApiPostCall in CippTenantModeDeploy to improve cache management. Added queryKey prop to CippTablePage in CippTenantTable for more consistent data fetching.
Passed a scope prop with required Microsoft Graph permissions to the ConnectToTenantsButton component in CippTenantModeDeploy. This enables the button to request the minimum necessary permissions during authentication.
Sets required Microsoft Graph API scopes on the AuthButton component to enable necessary permissions for delegated permission grants, directory, and app role assignments.
Introduces a promptBeforeAuth prop to CIPPM365OAuthButton, displaying a confirmation dialog before starting authentication. Updates CippTenantModeDeploy to use this feature, prompting users when changing the partner tenant to prevent accidental changes.
Added display of current tenant and authenticated user information, including organization name, tenant ID, user display name, and partner status, to the CIPPDeploymentUpdateTokens component. Loading states with skeletons and partner type chips are also included for improved user feedback.
Calls appIdInfo.refetch() when the refresh token is stored successfully to ensure related data is updated. This helps keep the UI in sync with the latest authentication state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )