Skip to content

Add support for nginx_name macro #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for nginx_name macro #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nginx-sys/build/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,8 @@ pub fn print_cargo_metadata<T: AsRef<Path>>(

if name == "nginx_build" {
println!("cargo::metadata=build={}", unquote(value));
} else if name == "nginx_name" {
println!("cargo::metadata=name={}", unquote(value));
} else if name == "nginx_version" {
println!("cargo::metadata=version={}", unquote(value));
} else if name == "nginx_version_number" {
Expand Down Expand Up @@ -453,6 +455,7 @@ RUST_CONF_HTTP=1
#endif

RUST_CONF_NGINX_BUILD=NGINX_VER_BUILD
RUST_CONF_NGINX_NAME=NGINX_NAME
Copy link
Member

@bavshin-f5 bavshin-f5 Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add an #ifdef guard and, preferably, a default value.

RUST_CONF_NGINX_VERSION=NGINX_VER
RUST_CONF_NGINX_VERSION_NUMBER=nginx_version
"
Expand Down