thread-safe spawn with ngx_notify #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschyska
force-pushed
the
main
branch
2 times, most recently
from
e327e07 to
e1c9191
Compare
pschyska
changed the title
pschyska
force-pushed
the
main
branch
4 times, most recently
from
1dcea34 to
53f60c3
Compare
schedule() can now be called from any thread and will move tasks to the event loop thread using ngx_notify (ngx_event_actions.notify). This enables receiving I/O notification from "sidecar runtimes" like async-compat, and requires less unsafe. The async example has been rewritten to use async_::spawn, demonstrating usage of reqwest and hyper clients wrapped in Compat to provide a tokio runtime environment while using the async_ Scheduler as executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As mentioned in #110 my POC for async via nginx-notify.
This would enable
schedule()to be called from other threads, e.g. async-compat or other "sidecar-runtime" setups. It also makes sure epoll is interrupted when there are IO completion notifications coming in from outside of the event loop, leading to prompt continuation.While this doesn't provide a native
hyper/clientas @bavshin-f5 wanted, it makes the default tokio implementation work via Compat. This would be a viable stopgap solution for us. I've added some examples, including hyper and reqwest. In the future, one could implement a "sidecar-runtime" approach as in async-compat natively that would use a separate epoll loop in a thread, or inject additional fds from the Rust side to nginx's epoll instance (if possible).Some notes:
ngx_notify, afaik this includes epoll, kqueue, eventport. Thread pools seem to have the same limitation, so this might be finestdas a dependency forasyncto reflect that (this would be a breaking change, but async Rust probably implies std anyways).Checklist
Before creating a PR, run through this checklist and mark each as complete.