Skip to content

fix: inconsistent casing of FROM and AS in Dockerfile #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

ShotaroMuraoka
Copy link
Contributor

Proposed changes

This PR fixes an inconsistency in the casing of FROM and AS in the Dockerfile.
Currently, FROM is uppercase while as is lowercase, which can trigger warnings in certain build environments.
To maintain consistency and follow Dockerfile best practices, AS is now capitalized.

Warning message before the fix:

 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 5)

There is no functional change in this PR; it is purely a stylistic improvement.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc.
  • I have added tests (when possible) that prove my fix is effective or that my feature works.
  • I have checked that all unit tests pass after adding my changes.
  • I have updated necessary documentation.
  • I have rebased my branch onto master.
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork.

@bavshin-f5
Copy link
Member

Thanks!

@bavshin-f5 bavshin-f5 merged commit bea775d into nginx:master Feb 13, 2025
@ShotaroMuraoka ShotaroMuraoka deleted the dockerfile-casing branch February 13, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants