Skip to content

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Oct 7, 2025

Proposed changes

This change adds the BuildOS field to our product telemetry.

Closes #4037

Additional changes:

  • Updates to both build/Dockerfile and build/ubi/Dockerfile to include ENV BUILD_OS

Blocked by #4008
Should not be merged until feat/inference-extension is merged

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Collected BuildOS for product telemetry

@shaun-nx shaun-nx requested a review from a team as a code owner October 7, 2025 13:47
@github-actions github-actions bot added enhancement New feature or request tests Pull requests that update tests labels Oct 7, 2025
@shaun-nx shaun-nx added the blocked Blocked by other issue label Oct 7, 2025
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.70%. Comparing base (5cd536c) to head (f8cfab6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4038      +/-   ##
==========================================
- Coverage   86.71%   86.70%   -0.01%     
==========================================
  Files         128      128              
  Lines       16758    16764       +6     
  Branches       62       62              
==========================================
+ Hits        14531    14535       +4     
- Misses       2043     2045       +2     
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done, just a couple of small comments

renovate bot and others added 6 commits October 9, 2025 15:43
* Update module google.golang.org/grpc to v1.76.0

| datasource | package                | from    | to      |
| ---------- | ---------------------- | ------- | ------- |
| go         | google.golang.org/grpc | v1.75.1 | v1.76.0 |


Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update files for renovate

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
| datasource | package                      | from    | to      |
| ---------- | ---------------------------- | ------- | ------- |
| go         | github.com/prometheus/common | v0.66.1 | v0.67.1 |

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
| datasource  | package              | from    | to      |
| ----------- | -------------------- | ------- | ------- |
| github-tags | github/codeql-action | v3.30.6 | v4.30.7 |

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update nginx Docker tag to v1.29.2

| datasource | package | from   | to     |
| ---------- | ------- | ------ | ------ |
| docker     | nginx   | 1.29.1 | 1.29.2 |


Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update README

* Remove package updates

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ciara Stacke <[email protected]>
…38dc (#4039)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file and removed tests Pull requests that update tests labels Oct 9, 2025
@bjee19
Copy link
Contributor

bjee19 commented Oct 9, 2025

@shaun-nx also looks like there is some rebase issue occurring since theres a few additional files

@github-actions github-actions bot added tests Pull requests that update tests and removed documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Oct 9, 2025
@shaun-nx shaun-nx requested review from bjee19 and sjberman October 9, 2025 18:24
@shaun-nx shaun-nx requested review from bjee19 and tataruty October 10, 2025 15:51
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice job

@shaun-nx
Copy link
Contributor Author

@bjee19 this is the logged telemetry output when using our Alpine images:
BuildOs is at the bottom

{
  "data": {
    "ImageSource": "local",
    "ProjectName": "NGF",
    "ProjectVersion": "edge",
    "ProjectArchitecture": "arm64",
    "ClusterID": "3ae8c039-79e4-4d0f-a930-b9b6fab5a66c",
    "ClusterVersion": "1.34.0",
    "ClusterPlatform": "kind",
    "InstallationID": "89c0f9e1-7fff-4f42-b2e6-4de6f2735108",
    "ClusterNodeCount": 1,
    "FlagNames": [
        ...
    ],
    "FlagValues": [
        ...
    ],
    "SnippetsFiltersDirectives": [],
    "SnippetsFiltersDirectivesCount": [],
    "GatewayCount": 1,
    "GatewayClassCount": 1,
    "HTTPRouteCount": 2,
    "TLSRouteCount": 0,
    "SecretCount": 0,
    "ServiceCount": 2,
    "EndpointCount": 2,
    "GRPCRouteCount": 0,
    "BackendTLSPolicyCount": 0,
    "GatewayAttachedClientSettingsPolicyCount": 0,
    "RouteAttachedClientSettingsPolicyCount": 0,
    "ObservabilityPolicyCount": 0,
    "NginxProxyCount": 1,
    "SnippetsFilterCount": 0,
    "UpstreamSettingsPolicyCount": 0,
    "GatewayAttachedNpCount": 0,
    "NginxPodCount": 1,
    "ControlPlanePodCount": 1,
    "NginxOneConnectionEnabled": false,
    "BuildOS": "alpine"
  }
}

@shaun-nx shaun-nx requested review from bjee19 and salonichf5 October 13, 2025 16:58
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though as a reminder, still is blocked on merging until the inference extension work gets merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Blocked by other issue enhancement New feature or request release-notes tests Pull requests that update tests

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

OpenShift Support: Product Telemetry

5 participants