-
Notifications
You must be signed in to change notification settings - Fork 114
Support configurable hostPort in helm chart #3321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @Gasoid! Welcome to the project! 🎉 Thanks for opening this pull request! |
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
Hey @Gasoid thanks for opening up this PR! We're going to hold off on this change right now because our architecture is changing in our next release (2.0) and there will be a different way to specify fields on the nginx container. We are about to merge our feature branch So after we merge our feature branch you could rewrite this PR to fit the new changes, it would probably look something like this PR #3319, OR we can probably just tag it alongside this issue #3240 which we'll complete by our 2.0 release. We're fine either way, so please let us know what you'd like to do! |
Hey @Gasoid, thanks for offering to do #3240, however that won't be necessary. That specific story is already scheduled in our current sprint so one of our team members will already be handling that. However, modifying this open PR after we merge our control data plane split changes into main is still an option and would be greatly appreciated to close out #2933.
That sort of depends, we're in a tricky spot right now where we're just wrapping up our changes to release our 2.0 with major changes to our architecture, so it just means that the solution to some of these stories might change slightly. However after we merge our changes into main in this open PR (should be by next week), all these issues are good to go.
#3157 looks like a great issue that won't be affected too much with the changes coming in so you could start on that. There just might be some additional places to update after #3318 goes in. |
Proposed changes
hostPort field for nginx container is configurable
Problem: hostPort is not configurable for now
Solution: In values file were added hostPort section
Testing: Tested manually.
Closes #2933
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes