Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluation session #10

Merged
merged 2 commits into from
Nov 2, 2024
Merged

evaluation session #10

merged 2 commits into from
Nov 2, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Nov 1, 2024

closes #6

@sbfnk sbfnk requested a review from seabbs November 1, 2024 16:54
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I wonder if it's enough to just have the random walk model here? In the ensemble session we pull in the other models without introduction and I had thought we would do that here.

@seabbs seabbs added this pull request to the merge queue Nov 2, 2024
@seabbs
Copy link
Contributor

seabbs commented Nov 2, 2024

I've queued for merging as I think it's good as is but point stands about multiple models and the course flow

Merged via the queue into main with commit 8f3a3d6 Nov 2, 2024
1 check passed
@seabbs seabbs deleted the evaluation-session branch November 2, 2024 07:12
@sbfnk
Copy link
Contributor Author

sbfnk commented Nov 2, 2024

This looks good but I wonder if it's enough to just have the random walk model here? In the ensemble session we pull in the other models without introduction and I had thought we would do that here.

I've added a bit of introduction in #11 (where the different models are also compared), both in the lecture and session. I didn't think there was time to do more and explain all the models etc. given that we're not using stan or showing any model code.

@seabbs
Copy link
Contributor

seabbs commented Nov 2, 2024

We could keep the r code simulation as extensions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session 2: Forecast evaluation
2 participants