-
Notifications
You must be signed in to change notification settings - Fork 223
Implement wave container commands #3954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JulianFlesch
wants to merge
49
commits into
nf-core:dev
Choose a base branch
from
JulianFlesch:feature/3952-create-waveyml
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 26 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
cb07e9d
WIP: Start working on wave commands: Add command dummies.
JulianFlesch aa40d8b
[automated] Update CHANGELOG.md
nf-core-bot 6b73c3c
added architecture
ningyuxin1999 5819387
Merge branch 'dev' into feature/3952-create-waveyml
ningyuxin1999 e689754
wire commands with functions
ningyuxin1999 c8873db
Merge branch 'feature/3952-create-waveyml' of https://github.com/Juli…
ningyuxin1999 8328f6f
containers obj
ningyuxin1999 6fba8ae
Merge branch 'dev' into feature/3952-create-waveyml
ningyuxin1999 78358ae
Update resolve module_dir. Change to using ValueError
JulianFlesch 4493cad
Add TODOs
JulianFlesch 1915c15
WIP: add container listing
JulianFlesch 109d0b8
Move container constants to global utils.
JulianFlesch e723d5b
Use constants from global utils. Change list_containers to return lis…
JulianFlesch f44757b
add dry-run to the containers create, fixed the uitls import and modu…
ningyuxin1999 7c369a4
Add contextmanager that extends set_wd but changes into a tempdir
JulianFlesch 81ddaf8
Add extracting container string from a module main.nf
JulianFlesch 882ed67
Rename method to match field name
JulianFlesch aa9fa01
Print container info as richt table
JulianFlesch 3e119a4
Merge branch 'feature/3952-create-waveyml' of github.com:JulianFlesch…
JulianFlesch 11228d4
Move calling wave to ModuleContainers class. Finish create method and…
JulianFlesch c08a6dd
Fix output encoding
JulianFlesch c6e8360
Remove comment
JulianFlesch 4317977
Add TODOs
JulianFlesch e1d7f7d
buildid and scanid saved to the dict
ningyuxin1999 6cd3380
Merge branch 'feature/3952-create-waveyml' of github.com:JulianFlesch…
JulianFlesch 180287e
meta yaml
ningyuxin1999 d6e744f
Update calling wave command to get buildId/scanId. Only add to outpu …
JulianFlesch ad5463c
Simplify create method
JulianFlesch e0edf97
Refactor to reuse key constants.
JulianFlesch 141c2b8
Add conda-lock information to containers dict
JulianFlesch 972cd5e
Fix space in url
JulianFlesch 78bd273
Implement conda lock functions. Do not fail in containers_from_meta i…
JulianFlesch ad640fa
Simplify class
JulianFlesch 9b821e7
Implement updating meta - WIP: sorting
JulianFlesch f117fca
Fix ModuleContainers initialisation
JulianFlesch d0f42cc
Fix expected meta.yml path
JulianFlesch 3ccd190
Update containers in meta.yml - WIP: sorting
JulianFlesch cf1dcfa
update container from meta method
JulianFlesch 76c64f2
Review: Rename conda lock methods
JulianFlesch 6a69fb2
Fix typo
JulianFlesch ff23c7d
Update nf_core/modules/containers.py
JulianFlesch b7e5102
Review command: Remove dry_run flag for module container creation#
JulianFlesch 2fa3538
remove unnecessary string casting
JulianFlesch af97d90
Review comment: Remove extra loop for conda-lock files
JulianFlesch 77e263e
Merge
JulianFlesch 8f3bfb1
Make wave container requests run concurrently
JulianFlesch 3221030
fix gathering concurrent results
JulianFlesch 6aca629
fix building conda section
JulianFlesch 69b6424
Remove threads option.
JulianFlesch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,3 +73,5 @@ authors: | |
| - "{{ author }}" | ||
| maintainers: | ||
| - "{{ author }}" | ||
|
|
||
| # TODO container-conversion: Add "containers" section | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.