-
Notifications
You must be signed in to change notification settings - Fork 36
Seqtk add relative sample sets and warning #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
073204d to
cd36140
Compare
|
I tried updating the log path to |
a626d7f to
bc8e8c2
Compare
Co-authored-by: Tori Giffin <[email protected]> Co-authored-by: Jonas Kjellin <[email protected]>
bc8e8c2 to
77b8e30
Compare
|
@nf-core-bot fix linting please |
Thanks for looking into this. I have now pushed the code that fixes this. |
|
@nkongenelly hope you don't mind, I solved the merge conflicts. |
Seqtk add relative sample sets and warning
This code allows subsampling to work with relative numbers too as the initial implementation limited it to absolute number of reads (#50).
seqtk_sample module itself allows passing fractions as the sample_size thus only our schema has been updated here to allow both integers and floats
It also writes a warning to .nextflow.log for every sample that does not reach the selected absolute sample_size
Fixes #60
Resolves #79
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).