Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging template updates for 3.1.2 #230

Closed
wants to merge 36 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
2ffef33
bump to 1.2.0dev
subwaystation Mar 25, 2024
6719020
Merge pull request #195 from subwaystation/dev
subwaystation Mar 25, 2024
1708db9
update workflow svg
subwaystation Apr 30, 2024
411a5dc
finished makeup2
subwaystation May 1, 2024
1aed918
Merge pull request #199 from nf-core/workflow_svg
subwaystation May 1, 2024
cdc1494
Template update for nf-core/tools version 2.14.0
nf-core-bot May 8, 2024
1e52981
Template update for nf-core/tools version 2.14.1
nf-core-bot May 9, 2024
d4a3def
Template update for nf-core/tools version 3.0.0
nf-core-bot Oct 8, 2024
f21fb92
Template update for nf-core/tools version 3.0.1
nf-core-bot Oct 9, 2024
e7671c6
Template update for nf-core/tools version 3.0.2
nf-core-bot Oct 11, 2024
62f8366
Template update for nf-core/tools version 3.1.0
nf-core-bot Dec 12, 2024
782e1c6
Template update for nf-core/tools version 3.1.1
nf-core-bot Dec 20, 2024
67b3acf
Merged changes from nf-core template
heuermh Jan 8, 2025
a6622ad
Fix up invalid input values
heuermh Jan 8, 2025
407820f
Fix up incorrectly typed input values
heuermh Jan 8, 2025
3c96fea
Add exceptions to files_exist lint check
heuermh Jan 8, 2025
62bf0eb
Removing unnecessary fastqc test files
heuermh Jan 8, 2025
3ffab69
Remove samplesheet output channel from PIPELINE_INITIALIZATION
heuermh Jan 8, 2025
6d2b02f
Update to nf-core/setup-nextflow@2 in custom CI jobs
heuermh Jan 8, 2025
57aee62
Add missing ch_versions channel
heuermh Jan 8, 2025
973bbe9
Fix up pangenome workflow
heuermh Jan 8, 2025
a67f17e
Attempt to fix lint errors
heuermh Jan 8, 2025
f038844
Set validation lenientMode to true
heuermh Jan 13, 2025
0947d1f
Address review comments
heuermh Jan 15, 2025
5a5941c
Merge pull request #213 from heuermh/merging-template-updates
heuermh Jan 15, 2025
784a9af
Update nf-core/smoothxg module to version 0.8.0
heuermh Jan 15, 2025
10beeb4
Merge pull request #216 from heuermh/smoothxg-0.8.0
subwaystation Jan 16, 2025
1d128e7
make n_haplotypes null
subwaystation Jan 17, 2025
b1bca81
Merge pull request #220 from nf-core/i218
heuermh Jan 17, 2025
c49fc01
Template update for nf-core/tools version 3.1.2
nf-core-bot Jan 20, 2025
2c5df9b
update multiqc to v1.26 to fix i224
subwaystation Jan 22, 2025
081a6e1
Add docs/images to files_unchanged
heuermh Jan 22, 2025
32ce9ce
Apply patch from https://github.com/nf-core/tools/pull/3416
heuermh Jan 22, 2025
0a8501e
Merge pull request #229 from heuermh/lint-i224
subwaystation Jan 22, 2025
aba25bf
Merge pull request #227 from nf-core/i224
heuermh Jan 22, 2025
1b1a646
Fixed merge conflicts
heuermh Jan 22, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Template update for nf-core/tools version 3.1.2
nf-core-bot committed Jan 20, 2025
commit c49fc01579c481aeb1932c9b22b44549cc98aede
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -46,6 +46,8 @@ jobs:
steps:
- name: Check out pipeline code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
fetch-depth: 0

- name: Set up Nextflow
uses: nf-core/setup-nextflow@v2
28 changes: 16 additions & 12 deletions .github/workflows/download_pipeline.yml
Original file line number Diff line number Diff line change
@@ -34,6 +34,17 @@ jobs:
REPO_LOWERCASE: ${{ steps.get_repo_properties.outputs.REPO_LOWERCASE }}
REPOTITLE_LOWERCASE: ${{ steps.get_repo_properties.outputs.REPOTITLE_LOWERCASE }}
REPO_BRANCH: ${{ steps.get_repo_properties.outputs.REPO_BRANCH }}
steps:
- name: Get the repository name and current branch
id: get_repo_properties
run: |
echo "REPO_LOWERCASE=${GITHUB_REPOSITORY,,}" >> "$GITHUB_OUTPUT"
echo "REPOTITLE_LOWERCASE=$(basename ${GITHUB_REPOSITORY,,})" >> "$GITHUB_OUTPUT"
echo "REPO_BRANCH=${{ github.event.inputs.testbranch || 'dev' }}" >> "$GITHUB_OUTPUT"

download:
runs-on: ubuntu-latest
needs: configure
steps:
- name: Install Nextflow
uses: nf-core/setup-nextflow@v2
@@ -56,21 +67,10 @@ jobs:
python -m pip install --upgrade pip
pip install git+https://github.com/nf-core/tools.git@dev

- name: Get the repository name and current branch set as environment variable
id: get_repo_properties
run: |
echo "REPO_LOWERCASE=${GITHUB_REPOSITORY,,}" >> "$GITHUB_OUTPUT"
echo "REPOTITLE_LOWERCASE=$(basename ${GITHUB_REPOSITORY,,})" >> "$GITHUB_OUTPUT"
echo "REPO_BRANCH=${{ github.event.inputs.testbranch || 'dev' }}" >> "$GITHUB_OUTPUT"

- name: Make a cache directory for the container images
run: |
mkdir -p ./singularity_container_images

download:
runs-on: ubuntu-latest
needs: configure
steps:
- name: Download the pipeline
env:
NXF_SINGULARITY_CACHEDIR: ./singularity_container_images
@@ -87,6 +87,9 @@ jobs:
- name: Inspect download
run: tree ./${{ needs.configure.outputs.REPOTITLE_LOWERCASE }}

- name: Inspect container images
run: tree ./singularity_container_images | tee ./container_initial

- name: Count the downloaded number of container images
id: count_initial
run: |
@@ -123,7 +126,8 @@ jobs:
final_count=${{ steps.count_afterwards.outputs.IMAGE_COUNT_AFTER }}
difference=$((final_count - initial_count))
echo "$difference additional container images were \n downloaded at runtime . The pipeline has no support for offline runs!"
tree ./singularity_container_images
tree ./singularity_container_images > ./container_afterwards
diff ./container_initial ./container_afterwards
exit 1
else
echo "The pipeline can be downloaded successfully!"
5 changes: 4 additions & 1 deletion .nf-core.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
lint:
files_unchanged:
- assets/nf-core-pangenome_logo_light.png
nf_core_version: 3.1.1
nf_core_version: 3.1.2
repository_type: pipeline
template:
author: Simon Heumos, Michael L Heuer
@@ -15,4 +15,7 @@ template:
name: pangenome
org: nf-core
outdir: .
skip_features:
- fastqc
- igenomes
version: 1.2.0dev
4 changes: 1 addition & 3 deletions CITATIONS.md
Original file line number Diff line number Diff line change
@@ -10,9 +10,7 @@

## Pipeline tools

- [FastQC](https://www.bioinformatics.babraham.ac.uk/projects/fastqc/)

> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online].- [MultiQC](https://pubmed.ncbi.nlm.nih.gov/27312411/)
- [MultiQC](https://pubmed.ncbi.nlm.nih.gov/27312411/)

> Ewels P, Magnusson M, Lundin S, Käller M. MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics. 2016 Oct 1;32(19):3047-8. doi: 10.1093/bioinformatics/btw354. Epub 2016 Jun 16. PubMed PMID: 27312411; PubMed Central PMCID: PMC5039924.

12 changes: 8 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -3,7 +3,9 @@
<source media="(prefers-color-scheme: dark)" srcset="docs/images/nf-core-pangenome_logo_dark.png">
<img alt="nf-core/pangenome" src="docs/images/nf-core-pangenome_logo_light.png">
</picture>
</h1>[![GitHub Actions CI Status](https://github.com/nf-core/pangenome/actions/workflows/ci.yml/badge.svg)](https://github.com/nf-core/pangenome/actions/workflows/ci.yml)
</h1>

[![GitHub Actions CI Status](https://github.com/nf-core/pangenome/actions/workflows/ci.yml/badge.svg)](https://github.com/nf-core/pangenome/actions/workflows/ci.yml)
[![GitHub Actions Linting Status](https://github.com/nf-core/pangenome/actions/workflows/linting.yml/badge.svg)](https://github.com/nf-core/pangenome/actions/workflows/linting.yml)[![AWS CI](https://img.shields.io/badge/CI%20tests-full%20size-FF9900?labelColor=000000&logo=Amazon%20AWS)](https://nf-co.re/pangenome/results)[![Cite with Zenodo](http://img.shields.io/badge/DOI-10.5281/zenodo.XXXXXXX-1073c8?labelColor=000000)](https://doi.org/10.5281/zenodo.XXXXXXX)
[![nf-test](https://img.shields.io/badge/unit_tests-nf--test-337ab7.svg)](https://www.nf-test.com)

@@ -27,12 +29,12 @@

<!-- TODO nf-core: Include a figure that guides the user through the major workflow steps. Many nf-core
workflows use the "tube map" design for that. See https://nf-co.re/docs/contributing/design_guidelines#examples for examples. -->
<!-- TODO nf-core: Fill in short bullet-pointed list of the default steps in the pipeline -->1. Read QC ([`FastQC`](https://www.bioinformatics.babraham.ac.uk/projects/fastqc/))2. Present QC for raw reads ([`MultiQC`](http://multiqc.info/))
<!-- TODO nf-core: Fill in short bullet-pointed list of the default steps in the pipeline -->2. Present QC for raw reads ([`MultiQC`](http://multiqc.info/))

## Usage

> [!NOTE]
> If you are new to Nextflow and nf-core, please refer to [this page](https://nf-co.re/docs/usage/installation) on how to set-up Nextflow.Make sure to [test your setup](https://nf-co.re/docs/usage/introduction#how-to-run-a-pipeline) with `-profile test` before running the workflow on actual data.
> If you are new to Nextflow and nf-core, please refer to [this page](https://nf-co.re/docs/usage/installation) on how to set-up Nextflow. Make sure to [test your setup](https://nf-co.re/docs/usage/introduction#how-to-run-a-pipeline) with `-profile test` before running the workflow on actual data.

<!-- TODO nf-core: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
Explain what rows and columns represent. For instance (please edit as appropriate):
@@ -89,7 +91,9 @@ For further information or help, don't hesitate to get in touch on the [Slack `#
## Citations

<!-- TODO nf-core: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file. -->
<!-- If you use nf-core/pangenome for your analysis, please cite it using the following doi: [10.5281/zenodo.XXXXXX](https://doi.org/10.5281/zenodo.XXXXXX) --><!-- TODO nf-core: Add bibliography of tools and data used in your pipeline -->
<!-- If you use nf-core/pangenome for your analysis, please cite it using the following doi: [10.5281/zenodo.XXXXXX](https://doi.org/10.5281/zenodo.XXXXXX) -->

<!-- TODO nf-core: Add bibliography of tools and data used in your pipeline -->

An extensive list of references for the tools used by the pipeline can be found in the [`CITATIONS.md`](CITATIONS.md) file.

Loading