Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old (bugged) version of Smoothxg breaks output paths #215

Closed
msgr0 opened this issue Jan 15, 2025 · 3 comments
Closed

Old (bugged) version of Smoothxg breaks output paths #215

msgr0 opened this issue Jan 15, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@msgr0
Copy link

msgr0 commented Jan 15, 2025

Description of the bug

Problem:
Running nf-core/pangenome on a multi sequence fasta file will result in the output pangenome to miss the last
PATH if and only if it is composed by a single fragment.

Explanation:
nf-core/pangenome in the dev branch and in the latest 1.1.2 release tag is using smoothxg ver 0.7.2.

This version of smoothxg suffers from this bug pangenome/pggb/#377, fixed in March 2024 (pangenome/smoothxg#206) and released in smoothxg ver. 0.8.0.

Updating the tool for nf-core/pangenome should result in a quick fix of this problem.

Thanks!

System information

  • Latest nextlfow version
  • Container engines: (podman, conda)
  • OS: AlmaLinux
  • nf-core/pangenome versions (dev, 1.1.2)
@msgr0 msgr0 added the bug Something isn't working label Jan 15, 2025
@subwaystation
Copy link
Collaborator

The latest smoothxg on https://bioconda.github.io/recipes/smoothxg/README.html is 0.8.0 so this should be straightforward to integrate. If nothing goes brr, this will land in dev this week.

@heuermh
Copy link
Contributor

heuermh commented Jan 15, 2025

smoothxg was updated to 0.8.0 in modules, now we need to update it here.

I will create a pull request once the merge in nf-core/modules completes.

@subwaystation
Copy link
Collaborator

Done @msgr0 #216.
This should already work out of the box, else re-open here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants