Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update smoothxg to v0.8.0 #7309

Merged
merged 3 commits into from
Jan 15, 2025
Merged

update smoothxg to v0.8.0 #7309

merged 3 commits into from
Jan 15, 2025

Conversation

msgr0
Copy link
Contributor

@msgr0 msgr0 commented Jan 15, 2025

PR checklist

Closes #XXX
Updates smoothxg to version 0.8.0, solving this issue (pangenome/pggb#377)

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@heuermh
Copy link
Contributor

heuermh commented Jan 15, 2025

Fixes nf-core/pangenome#215

@heuermh
Copy link
Contributor

heuermh commented Jan 15, 2025

Thank you, @msgr0!

@heuermh heuermh added this pull request to the merge queue Jan 15, 2025
Merged via the queue into nf-core:master with commit 84d99db Jan 15, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants