Skip to content

fix: escape blasttab plus in schema regex#141

Merged
charles-plessy merged 1 commit into
nf-core:devfrom
sapunyangkut:codex/issue-136-escape-blasttab-plus
Jul 13, 2026
Merged

fix: escape blasttab plus in schema regex#141
charles-plessy merged 1 commit into
nf-core:devfrom
sapunyangkut:codex/issue-136-escape-blasttab-plus

Conversation

@sapunyangkut

Copy link
Copy Markdown
Contributor

Summary

  • escape the literal + in the documented blasttab+ export format
  • stop the schema regex from rejecting blasttab+ and accepting invalid values such as blasttabb

Closes #136.

Validation

  • python -m json.tool nextflow_schema.json
  • Python and JavaScript regex boundary checks for valid, invalid, and comma-separated values
  • git diff --check

PR checklist

  • This description explains the bug and the one-token schema correction.
  • The change is limited to the existing schema regex; pipeline runtime tests and test-data changes are not applicable.

Signed-off-by: sapunyangkut <302607731+sapunyangkut@users.noreply.github.com>
@charles-plessy

Copy link
Copy Markdown
Collaborator

Thanks a lot ! Please note that proper blasttab+ support will need to upgrade LAST to version 1652 as the older versions do not output the extra columns when converting MAF files produced by last-split.

@charles-plessy
charles-plessy merged commit 0bb3e3c into nf-core:dev Jul 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants