Repository navigation
New module: fairbioheaders/validate - #13509
Draft
adamjohnwright wants to merge 1 commit into
Draft
adamjohnwright wants to merge 1 commit into
adamjohnwright wants to merge 1 commit into
Conversation
Add FAIRBIOHEADERS_VALIDATE, which wraps `bioheaders validate` from the fair-bioheaders toolkit to validate standalone FAIR-bioHeaders metadata (FHR, FHP or FHGFF3, as JSON, YAML or JSON-LD) against its schema without a sequence file. Invalid metadata, or metadata citing a schema version the toolkit does not bundle, fails the task. Generated by Claude Code Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
4 tasks done
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Author
|
On the size warning: as with #13492, this is one module. 1,955 of the added lines are the two generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
fairbioheaders/validate, which wrapsbioheaders validatefrom fair-bioheaders. It validates standalone FAIR-bioHeaders metadata (FHR, FHP or FHGFF3, as JSON, YAML or JSON-LD) against the schema itsschemaURL selects, without a sequence file.Motivation: in nf-core/genomeassembler#250 the per-sample metadata comes from user configuration. Checking it at the start of a run catches mistakes before hours of assembly, rather than at the export step. For files that already carry a header,
fairbioheaders/verifyis the counterpart.Input:
[ meta, metadata ].Outputs:
report:<prefix>.validate.txt, naming the file and the resulttopic: versionsNotes for reviewers:
fair-bioheaders=0.8.5(MPL-2.0, bio.toolsfair-bioheaders). Containers were built withnf-core modules containers create(Seqera, linux/amd64 and linux/arm64). About 1,950 of the added lines are the two generated.conda-lockfiles.bioheaders --versionprints a bare version (0.8.5), emitted viatopic: versions.prefixare single-quoted in the script, and--comes before positional arguments, because sample IDs in assembly pipelines can contain spaces, quotes or a leading-(tested by hand withit's $xand-dash). Happy to drop this if reviewers prefer the plainer style.collectFile, so no test-datasets PR is needed; I can move it to test-datasets if preferred.meta, so pipelines can gate downstream steps on it.AI assistance: the module was prepared with Claude Code (Claude Opus 5.5), which also ran an adversarial review. I have reviewed the code, the tests and the snapshots, and I will handle review comments.
Generated by Claude Code
PR checklist
Part of #13491 (second of four fairbioheaders modules; independent of #13492).
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularity(not run locally; the Seqera Singularity image was pulled and smoke-tested by hand)nf-core modules test <MODULE> --profile conda🤖 Generated with Claude Code