Add North Carolina State institutional Config#1127
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sweavs111
requested review from
a team,
FriederikeHanssen and
matthdsm
and removed request for
a team
jfy133
left a comment
jfy133
left a comment
There was a problem hiding this comment.
Small suggestion but otherwise LGTM
| max_cpus = 24 | ||
| max_time = 120.h | ||
|
|
||
| // Default GPU allocation. Override at runtime with --hazel_gpu 'gpu:<type>:<num>' |
There was a problem hiding this comment.
Add a validation{} scope ignoreParams list to ignore this to avoid ugly warning for users
(Review from phone, so no real example but check other configs)
| memory: 128.GB, | ||
| cpus: 24, | ||
| time: 120.h |
There was a problem hiding this comment.
Not wrong, but suggested to have in only one place (e.g. reuse the params to support old pipelines) to avoid drift with updates.
| ## Load Nextflow and Singularity environment modules | ||
| module purge # Optional, unload any currently loaded modules. | ||
| module load nextflow/26.04.3 | ||
| module load singularity |
There was a problem hiding this comment.
If this is required to make singularity/apptainer available, I suggest adding a beforeScript to load the module to the process as well.
(Slurm environment forwarding works great except when it doesn't.)
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Updated documentation to reflect changes in module loading instructions.
|
Thank you for the review and the suggestions. I have made the edits and the PR is ready for re-review. Sorry for lots of commits. |
3 participants
name: New Config for NC State
about: A new cluster config
Please follow these steps before submitting your PR:
[WIP]in its titlemasterbranchSteps for adding a new config profile:
conf/directorydocs/directorynfcore_custom.configfile in the top-level directoryprofile:scope in.github/workflows/main.yml.github/CODEOWNERS(**/<custom-profile>** @<github-username>)