orchestrator: avoid unwraps when building reqwest client; fallback to default Client#1992
Open
atifflc wants to merge 6 commits intonexus-xyz:mainfrom
Open
orchestrator: avoid unwraps when building reqwest client; fallback to default Client#1992atifflc wants to merge 6 commits intonexus-xyz:mainfrom
atifflc wants to merge 6 commits intonexus-xyz:mainfrom
Conversation
Collaborator
|
Did you intend to remove comments and tests? |
… git-deps (stwo, nexus-zkvm)
… git-deps (stwo, nexus-zkvm)
Contributor
Author
|
Thanks — good catch. I intentionally removed the local backup files / stray comments/tests because they were [stale / duplicate / noisy / causing build warnings]. If you’d prefer I restore any specific tests or comments, tell me which ones and I’ll add a follow-up commit. CI will re-run after I push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace unwrap/expect used when building reqwest::Client with a safe fallback to Client::new() and a warning message to avoid panics on client construction failure.