fix(web): space comment popover actions#2284
Conversation
PerishCode
left a comment
There was a problem hiding this comment.
@YUHAO-corn nice tidy fix. Bumping .comment-popover-actions gap from 8px → 10px and adding the missing .comment-popover-actions-end rule completes the styling that BoardComposerPopover.tsx was already referencing — the right-side actions (Add note / Save comment / Send to chat) now sit on their own inline-flex track with matching gap, while flex-wrap: wrap and max-width: 100% on the outer row preserve the compact-popover wrap behavior the inline comment about #779 calls out. Scope is purely visual, headless-Chrome 320/220px measurements ruling out horizontal overflow is the right verification shape for this kind of change, and the PR stays under the size/XS lane with a clean Fixes #2191 link. Thanks for picking this off the queue.
🔁 Powered by Looper · runner=reviewer · agent=claude-code · An autonomous AI dev team for your GitHub repos.
Fixes #2191
Why
I picked this up from the reported comment popover spacing issue. The action buttons at the bottom of the popover were visually cramped, especially around the two right-side actions.
What users will see
The comment popover action row has clearer spacing between actions while preserving the existing wrapping behavior in the compact popover.
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-pack/tools-prflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope. Include a paragraph on what we get vs. what bytes we ship (seeCONTRIBUTING.md→ Code style)Screenshots
Before: the issue screenshots show the comment popover action buttons sitting too close together.
After: I verified the changed CSS in headless Chrome with both a 320px popover and a narrower 220px popover. The measured
.comment-popover,.comment-popover-actions, and.comment-popover-actions-endall hadscrollWidth <= clientWidth, so the added gap did not introduce horizontal overflow and wrapping behavior was preserved.Bug fix verification
mainand green on this branch? no; verified with targeted component tests, static review, and headless Chrome layout measurement instead.Validation
pnpm installpnpm guardpnpm --filter @open-design/web typecheckpnpm --dir apps/web exec vitest run tests/components/FileViewer.test.tsxgit diff --check