-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Fix homepage localization for chip labels and translations #2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SunayKulkarni
wants to merge
10
commits into
nexu-io:main
Choose a base branch
from
SunayKulkarni:fix-homepage-i18n
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−16
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7459aba
Fix incomplete homepage localization (chip labels + translations)
SunayKulkarni f026e56
Fix i18n key mismatch and remove unsafe cast; localize tooltips
SunayKulkarni 0723732
Enforce type-safe i18n keys for HomeHero chips
SunayKulkarni 6244913
Remove unused labelKey for migrate chips to avoid duplicate i18n sources
SunayKulkarni bba7388
Restore labelKey for migrate chips to satisfy HomeHeroChip type
SunayKulkarni 7f9a7cb
Add zh-CN localization test for HomeHero rail labels and tooltips
SunayKulkarni 26fa6d9
Refactor HomeHeroChip into create/migrate union and fix type-safe ren…
SunayKulkarni 16ab5d8
Fix type errors: remove label from CreateChip, add example-live-artif…
SunayKulkarni 9199903
Remove dead TypeTabBar component; RailGroup is the single tab renderer
SunayKulkarni 465819d
Remove unused labelKey from CreateChip; homeHeroChipLabel is the sing…
SunayKulkarni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regression test only asserts one always-visible create-chip label (
🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.prototype) and one tooltip (hyperframes), and it never opens theMoreshortcuts menu. That means the zh-CN copy for the changed migrate shortcuts (create-plugin,figma,template) can regress without this suite failing, even though the PR body says no mixed English homepage UI remains. Please extend this test to openhome-hero-shortcuts-triggerunderzh-CNand assert the localized labels/titles for the shortcut chips as well, so the homepage-localization guarantee is covered across both rail rows.