fix(tools-pack): focus existing AppImage instead of silent EADDRINUSE on second launch#2262
Open
n8k99 wants to merge 2 commits into
Open
fix(tools-pack): focus existing AppImage instead of silent EADDRINUSE on second launch#2262n8k99 wants to merge 2 commits into
n8k99 wants to merge 2 commits into
Conversation
Two new design systems based on Nathan's existing DPN.md / DPS.md style guides (canonical at ~/Documents/DPN.md and ~/Documents/DPS.md). They codify a single design language with a dark face (Noir) and a light face (Solar), originally authored for AI image generation and now extended into UI tokens via the typographic-roles addition from 2026-04-27. DragonPunk Noir (DPN) — dark-by-default: - Canvas: Void Black #0A0A0F (warmest possible black, never #000) - Ink: Dragon Gold #FFB800 — load-bearing read color at ~12:1 on void - Accent + Focus glow: Neon Cyan #00F5FF — single token (~110:1 on void lets it serve both readable-accent and focus-glow roles) - Neon family: Magenta #FF2D95, Purple #9D00FF, Toxic Green #39FF14 - Warm spike: Ember #FF6B35 (warn), Crimson #8B0000 (deep danger), Bronze #CD7F32 (stale/disabled) - Plan 9 / Acme / NeXTSTEP lineage: square corners, no shadows, no blur, state-change motion only DragonPunk Solar (DPS) — light-face twin: - Canvas: Solar White #FFF8E1 (cream warmed toward gold, never sterile) - Ink: Bole #3D1208 — Renaissance gilders' red-clay underground at ~13:1 - Readable accent: Rubric #B82F08 — manuscript-red, ~5.5:1 - Focus glow only: Plasma Cyan #00D4FF (cyan-on-cream collapses to ~1.7:1, so DPS splits the role into Rubric + Cyan rather than collapsing into one token like DPN does) - Dark-mode override flips DPS to DPN's full token set (same brand, light face flips to dark face — not duplicated values per Lens B) Both files satisfy the 9-section schema (Visual Theme / Color / Typography / Spacing / Layout / Components / Motion / Voice / Anti-patterns), include real CSS in :root blocks, use the [data-theme="dark"] override pattern, and target prefers-reduced-motion to specific selectors rather than global *. Substantive anti-patterns named (no rounded corners, no drop shadows, no ambient idle animation, no centered prose, no cyan-as-text on cream, etc.). Prior art names real specifics: Plan 9, Acme, NeXTSTEP, Blade Runner 2049, Renaissance manuscript rubrication, the Mixxx LateNight skins, dpn-void.css / dps-solar.css. Category: Bold & Expressive for both. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… on second launch startPackedLinuxApp had no already-running detection. Every CMD+SPACE "Open Design" launch after the first one tried to bind the same desktop IPC socket at /tmp/open-design/ipc/<ns>/desktop.sock, hit EADDRINUSE, and exited silently. Observed as the launcher "doing nothing" on the second click. This adds detectRunningLinuxApp() (mirrors stopPackedLinuxApp's marker + stamp + IPC liveness validation) and focusLinuxWindow() (swaymsg / i3-msg / hyprctl by env, wmctrl as universal fallback), so the fast path focuses an existing window instead of spawning a duplicate. - LinuxStartSource widened to include "already-running" - LinuxStartResult gains optional focusMethod - 5 new tests for focusAttemptsForLinuxWindow (66 total, all pass) - pnpm guard / typecheck / --filter @open-design/tools-pack test all green
lefarcen
added
size/XL
Contributor
|
@n8k99 I'm holding off on generating review comments for #2262 because this pull request has merge conflicts right now. Please resolve the conflicts with main and push the updated branch. Once that's done, request or wait for the review to run again and I'll take another look. 🔁 Powered by Looper · runner=reviewer · agent=claude-code · An autonomous AI dev team for your GitHub repos. |
lefarcen
reviewed
May 19, 2026
Contributor
lefarcen
left a comment
lefarcen
left a comment
There was a problem hiding this comment.
Hi @n8k99! The Summary gives a clear picture of the AppImage second-launch failure and the intended already-running path. One quick body-template ask before pool review: could you add a ## Surface area checklist and a ## Validation section? The current test-plan bullets are helpful; putting them under Validation and ticking the affected surface area will make the review/release scope easier to scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startPackedLinuxApphad no already-running detection. The .desktop entry runsopen-designwhich always callslinux start, which tries to bind the same desktop IPC socket — second click silentlyEADDRINUSEs and the launcher appears to "do nothing."This adds:
detectRunningLinuxApp()— mirrorsstopPackedLinuxApp's marker + stamp + IPC liveness validation, but returns the live instance instead of killing itfocusLinuxWindow()— triesswaymsg/i3-msg/hyprctlbased on WM env vars, withwmctrlas the universal fallbackstartPackedLinuxApp: if a live instance is detected, focus its window and returnsource: "already-running"(new variant)Test plan
pnpm --filter @open-design/tools-pack typecheck— cleanpnpm --filter @open-design/tools-pack test— 66 tests, 5 new forfocusAttemptsForLinuxWindowpnpm guard— cleansource: "installed"), warm-start hits new path (source: "already-running",focusMethod: "swaymsg", status returned via IPC)--forceoption surfaced on the newpr mergesubcommand inforgejo-cli(matches the never-force-merge hard rail)Notes
LinuxStartResultwidens with optionalfocusMethod(string|null), populated only on"already-running". Backward compatible — existing consumers ignore the new field.