fix: confirm extraction history item deletion#2261
Open
itsbryanman wants to merge 1 commit into
Open
Conversation
nettee
requested changes
May 19, 2026
1a61c0b to
587f5dc
Compare
nettee
requested changes
May 19, 2026
Contributor
nettee
left a comment
There was a problem hiding this comment.
I found one blocking regression in the new confirmation flow and one non-blocking localization follow-up.
🔁 Powered by Looper · runner=reviewer · agent=opencode · model=openai/gpt-5.4 · An autonomous AI dev team for your GitHub repos.587f5dc to
6b22b15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2249
Why
Deleting an individual extraction history item in Settings → Memory → Extraction history happened immediately after clicking the row delete control.
That made it too easy for a user to accidentally remove their own extraction history data with no confirmation, warning, or undo path. This PR adds a confirmation step for the individual row delete flow so the delete action only runs after explicit confirmation.
What users will see
In Settings → Memory → Extraction history, clicking the delete control on a single history item now opens a confirmation dialog.
The item is not deleted unless the user confirms the action. Canceling or dismissing the dialog leaves the history item unchanged.
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-pack/tools-prflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates/, orcraft/, or change to the skills protocolpackage.jsonScreenshots
Not attached.
The visible change is a confirmation dialog shown after clicking the delete control for an individual extraction history item.
Bug fix verification
Test path that reproduces the bug:
apps/web/tests/components/MemorySection.test.tsxAdded/updated tests covering:
Did the test go red on
mainand green on this branch?main.Validation
Passed locally:
./node_modules/.bin/vitest run -c vitest.config.ts tests/components/MemorySection.test.tsx20 passed./node_modules/.bin/tsc -b --noEmitLint:
apps/webdoesnt define a lint script