Fix/banner sidebar 859#1146
Open
masher-pp wants to merge 2 commits intonexu-io:mainfrom
Open
Conversation
added 2 commits
April 14, 2026 20:36
将更新通知横幅从左侧移动到右侧,避免与侧边栏导航元素重叠。 - 修改文件: apps/desktop/src/runtime-page.css - 变更: left: 12px → right: 12px,添加 left: auto
lefarcen
reviewed
Apr 18, 2026
Collaborator
lefarcen
left a comment
There was a problem hiding this comment.
Hi @masher-pp! 🎉
Wow, thanks for fixing the update banner overlap with the sidebar—what a thoughtful UX improvement! 🙌 Moving it to the right side with left: auto is a clean solution that should resolve #859 nicely.
A few quick thoughts:
- Consider adding a media query for very narrow viewports (e.g.,
@media (max-width: 400px)), where right positioning might still cause minor overlaps or clipping. - The checklist looks solid—no secrets, types clean, tests pass. Great work on the affected areas assessment!
This looks excellent overall. We'll review promptly (target: 24h). Questions or updates? Push here!
Join our communities:
- Feishu: https://applink.feishu.cn/client/chat/chatter/add_by_link?link_token=90emc2e9-86cd-4723-b455-ca41b70f162d
- Discord: https://discord.gg/nexu
Thanks for making Nexu better!
Nexu Team
| @@ -1294,7 +1294,8 @@ body, | |||
| .update-card { | |||
| position: fixed; | |||
| bottom: 80px; | |||
Collaborator
There was a problem hiding this comment.
✅ Perfect fix—right: 12px; left: auto; cleanly repositions without side effects. Consider box-shadow if needed for visual separation from sidebar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
修复更新通知横幅遮挡侧边栏的问题,将横幅从左侧移动到右侧
Why
更新通知横幅在左侧会遮挡侧边栏导航元素,影响用户操作。移动到右侧后避免重叠,提升用户体验。
Closes #859
How
Affected areas
Checklist
Screenshots / recordings