fix: handle nullable gifted credit grants in desktop rewards#1108
Open
fix: handle nullable gifted credit grants in desktop rewards#1108
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
lefarcen
approved these changes
Apr 15, 2026
lefarcen
approved these changes
Apr 15, 2026
The controller ready endpoint does not return openclawPort, so the E2E test always fell back to 18789. When that port is occupied on the CI runner, OpenClaw auto-assigns a different port and the health check times out. Scan 18789-18791 to match the bash harness behavior.
Deploying nexu-docs with
|
| Latest commit: |
c49549a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ca5cc4b.nexu-docs.pages.dev |
| Branch Preview URL: | https://fix-issue-1085-gifted-credit.nexu-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix desktop rewards so gifted credits continue to render correctly when cloud credit grant records contain nullable expiry timestamps or newer gifted source names.
Why
Closes #1085.
The desktop rewards view could fall back to
0or misclassify gifted credits as package credits because the shared credit schema rejected real cloud records withexpiresAt = null, and the gifted-balance breakdown only recognized a narrow set of source names.How
sourcevalues beyond the current known enum while preserving a typed list of known valuesexpiresAtvalues in shared credit schemas to match production cloud dataAffected areas
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpassespnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Notes for reviewers
Validated end-to-end in the desktop app against the real local rewards flow: the sidebar balance card and the expanded rewards popover both show gifted balance separately from package balance.