-
Notifications
You must be signed in to change notification settings - Fork 19
File behaviour for restarts and diagnostics #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jwallwork23
wants to merge
16
commits into
issue990_xios_write-then-read-take3
Choose a base branch
from
issue935_xios-landmask
base: issue990_xios_write-then-read-take3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
File behaviour for restarts and diagnostics #989
jwallwork23
wants to merge
16
commits into
issue990_xios_write-then-read-take3
from
issue935_xios-landmask
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ae4048 to
8b5f23a
Compare
… splitting for now
8b5f23a to
dfa80d5
Compare
Otherwise, it will be zeroed in file splits after the first
3582343 to
c16977a
Compare
dfa80d5 to
33e0a3e
Compare
183435f to
279efaa
Compare
279efaa to
e157a0c
Compare
This was
linked to
issues
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request
ICCS
Tasks or reviews for the ICCS team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File behaviour for restarts and diagnostics
Fixes #935
Fixes #977
Fixes #997
Fixes #898
Merges into #999
Task List
Change Description
This PR fixes several things related to how restarts and diagnostics are configured with XIOS:
Whilst file patterns are made consistent with what's used elsewhere in nextSIM-DG, the output filenames show the range of datetimes separated by a hyphen.
In this PR, I also overhauled the
createFilemember function, inlining many of the setters with only a single call site.Test Description
Tests are updated to account for the new behaviour.
TODO - to test the diagnostics are written out.
I decided to drop
XiosFile_testbecause it is no longer needed. This meant that we could drop the annoyingunittestspecial case.Documentation Impact
TODO
Pre-Request Checklist