-
Notifications
You must be signed in to change notification settings - Fork 19
Enable multiplatform build of the docker image #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Just adds "platforms: linux/amd64,linux/arm64" to docker.yml
|
It wasn't that easy, unfortunately! The arm64 build fails with a problem with spack: (link to failure in log). Strangely, the image builds fine on my M1 Mac. Any ideas @TomMelt? |
|
Hi @einola and @auraoupa , it's hard for me to look into these things because I don't have an FWIW, if you managed to build the docker image locally, you could push it manually to the github container repository (under a different name) and users could download it from there. Would that work? |
|
@einola , here's some instructions on how to push a new image to the GHCR: You need to create a Github access token but it tells you how to do it in the guide. You then use that to Make sure you give it a different name e.g., |
|
I probably wont be able to do it before tomorrow but I will take a look at the docker github workflow |
|
Hi @TomMelt, Good suggestions - thanks! I'll build locally and push to ghcr, as you suggested. It would be nice to have multi-platform working, but if we take this workaround for now, then there's no rush. |
|
Well, I built it with and then did and but got And I have no idea how to authenticate :/ |
|
You need to setup a personal access token. The instructions are linked here: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-with-a-personal-access-token-classic In step 1 you create a token on GitHub, then you set it as an environment variable on your system. Then you should be able to authenticate when pushing to GitHub container registry. When you create the token make sure you give it the permissions listed in the instructions. I'm back from the conference next week so we can have a teams call if you want and I can guide you through the process |
Enable multiplatform build of the docker image
Fixes #864
Task List
Change Description
Add "platforms: linux/amd64,linux/arm64" to docker.yml. This should allow github to build a multiplatform image.
Test Description
Trigger a build and confirm that the image built works on both amd64 and arm64 machines.
Documentation Impact
N/A
Other Details
None
Pre-Request Checklist