Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEX-6555] Make gem compatible with Ruby 3 #1

Merged
merged 1 commit into from
May 8, 2024
Merged

[NEX-6555] Make gem compatible with Ruby 3 #1

merged 1 commit into from
May 8, 2024

Conversation

natedemery
Copy link
Collaborator

Makes this fork of smart_listing compatible with Ruby 3. This is based on this example PR in the original repo

@natedemery natedemery requested a review from a team May 6, 2024 18:26
CJStadler
CJStadler approved these changes May 7, 2024
View reviewed changes
Copy link

@CJStadler CJStadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will you open a PR on the nextrequest repo to use this fork?

@natedemery
Copy link
Collaborator Author

@CJStadler that's next on the list!

@natedemery natedemery merged commit f7ea105 into main May 8, 2024
@natedemery natedemery deleted the ruby_3 branch May 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJStadler CJStadler CJStadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natedemery @CJStadler