Skip to content

fix(ui): support comma separator in allowed users field #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keithy wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix(ui): support comma separator in allowed users field #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/web/src/i18n/locales/en/channels.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
"requireMention": "Require @mention",
"enabled": "Enabled",
"allowedUsers": "Allowed Users",
"allowedUsersPlaceholder": "One user ID per line",
"allowedUsersPlaceholder": "One user ID per line or comma-separated",
"skillsFilter": "Skills Filter",
"skillsPlaceholder": "One skill name per line (empty = inherit)",
"toolAllow": "Tool Allow",
Expand Down
2 changes: 1 addition & 1 deletion ui/web/src/pages/channels/channel-fields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ function FieldRenderer({
id={id}
value={Array.isArray(value) ? (value as string[]).join("\n") : ""}
onChange={(e) => {
const lines = e.target.value.split("\n").map((l) => l.trim()).filter(Boolean);
const lines = e.target.value.split(/[\n,]/).map((l) => l.trim()).filter(Boolean);
onChange(lines.length > 0 ? lines : undefined);
}}
placeholder={t("groupOverrides.fields.allowedUsersPlaceholder")}
Expand Down
2 changes: 1 addition & 1 deletion ui/web/src/pages/channels/channel-schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const configSchema: Record<string, FieldDef[]> = {
{ key: "reaction_level", label: "Reaction Level", type: "select", options: [{ value: "off", label: "Off" }, { value: "minimal", label: "Minimal" }, { value: "full", label: "Full" }], defaultValue: "full" },
{ key: "media_max_bytes", label: "Max Media Size (bytes)", type: "number", defaultValue: 20971520, help: "Default: 20MB" },
{ key: "link_preview", label: "Link Preview", type: "boolean", defaultValue: true },
{ key: "allow_from", label: "Allowed Users", type: "tags", help: "User IDs or @usernames, one per line" },
{ key: "allow_from", label: "Allowed Users", type: "tags", help: "User IDs or @usernames, one per line or comma-separated" },
{ key: "block_reply", label: "Block Reply", type: "select", options: blockReplyOptions, defaultValue: "inherit", help: "Deliver intermediate text during tool iterations" },
],
discord: [
Expand Down