Allow users to provide implicit managed identity to Azure Batch when pool identity is set to true #6144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pool identity is set to true It turns out Fusion can automatically pick up a managed identity that is available, however in the first iteration we insisted users provide an explicit identity. If we avoid setting FUSION_AZ_MSI_CLIENT_ID fusion will pick up this identity and authenticate to Azure Storage automatically, with no details shared externally. I've overloaded the config item to allow users to set it to 'true', which will avoid setting FUSION_AZ_MSI_CLIENT_ID and enable Fusion to do this. This isn't a great implementation, it should probably use a dedicated config item like AzManagedIdentityOpts does for Nextflow itself, but it's a POC that allows me to test the methods. Signed-off-by: adamrtalbot <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pditommaso
reviewed
May 30, 2025
plugins/nf-azure/src/main/nextflow/cloud/azure/fusion/AzFusionEnv.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: adamrtalbot <[email protected]>
pditommaso
reviewed
May 30, 2025
Co-authored-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Adam Talbot <[email protected]>
pditommaso
force-pushed
the
master
branch
3 times, most recently
from
b4b321e to
069653d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out Fusion can automatically pick up a managed identity that is available, however in the first iteration we insisted users provide an explicit identity.
If we avoid setting FUSION_AZ_MSI_CLIENT_ID fusion will pick up this identity and authenticate to Azure Storage automatically, with no details shared externally.
I've overloaded the config item to allow users to set it to 'true', which will avoid setting FUSION_AZ_MSI_CLIENT_ID and enable Fusion to do this.
This isn't a great implementation, it should probably use a dedicated config item like AzManagedIdentityOpts does for Nextflow itself, but it's a POC that allows me to test the methods.
Signed-off-by: adamrtalbot [email protected]
Hi! Thanks for contributing to Nextflow.
When submitting a Pull Request, please sign-off the DCO [1] to certify that you are the author of the contribution and you adhere to Nextflow's open source license [2] by adding a
Signed-off-byline to the contribution commit message. See [3] for more details.