Skip to content

fix: Don't retry join on non-recoverable errors #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ivansss merged 1 commit into from
Sep 10, 2026
Merged

fix: Don't retry join on non-recoverable errors #2703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion NextcloudTalk/Rooms/NCRoomsManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,9 @@ class NCRoomsManager: NSObject, CallViewControllerDelegate {
// Set room as active
self.activeRooms[token] = controller
} else {
if self.joiningAttempts < 3 && statusCode != 403 {
// Some request are not recoverable by a retry - don't even try it
let nonRecoverableErrorCodes = [403, 429, 503]
if self.joiningAttempts < 3 && !nonRecoverableErrorCodes.contains(statusCode) {
NCLog.log("Error joining room, retrying. \(self.joiningAttempts)")
self.joiningAttempts += 1
self.joinRoomHelper(token, forAccountId: accountId, forCall: call)
Expand Down
Loading