fix: Prevent starting the same file download twice - #2699
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
SystemKeeper
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2694
fileParameter.fileStatus?.isDownloadingguards in the chat could never be true since feat: Improve file downloading handling聽#2598, so every tap started another download of the same file. Chat downloads now go throughChatFileDownloader, which already shared one download between callers asking for the same file.NCChatFileControllerreports through a completion handler instead of a delegate, so the caller's intent stays at the call site. This removesmessageTypeandactionType, which only existed to tell the callbacks apart again.ChatFileDownloaderwith an entry it never cleans up, blocking that file for the rest of the session.NCChatFileControllerWrappertoChatFileDownloader: it no longer wraps a delegate, and the name now matchesChatFileUploader.fileStatusbranch inBaseChatTableViewCell+File.Not changed here: the media viewer keeps its own
NCChatFileControllerbecause it needs to cancel downloads for pages the user swiped past, andChatFileDownloaderdeliberately has no cancellation. Repeated requests for the same file still queue one handler each, as before.How to test
馃 AI (if applicable)