fix: Only hand polling over to the chat relay once the room is joined on the HPB - #2689
Merged
Merged
Conversation
SystemKeeper
reviewed
Sep 6, 2026
…joined on the HPB Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Ivansss
force-pushed
the
fix/noid/chat-relay-join-race
branch
from
September 8, 2026 14:24
9bb1b7b to
494fb28
Compare
SystemKeeper
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat relay was armed on the chat API's 304 alone, without checking that our signaling session had
joined the room on the HPB. So we stopped polling before the HPB was sending us anything, and any
message sent in between was never received.
The relay now waits for the HPB room ack (new
joinedRoomToken) and keeps long polling until then.🤖 AI (if applicable)