Skip to content

fix(chat): guard note to self by capability&avoid crashes - #6724

Open
mahibi wants to merge 3 commits into
masterfrom
fixHttp404Exception
Open

mahibi wants to merge 3 commits into
masterfrom
fixHttp404Exception

Conversation

@mahibi

@mahibi mahibi commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@mahibi mahibi added this to the 25.1.0 milestone Sep 19, 2026
@mahibi mahibi self-assigned this Sep 19, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label Sep 19, 2026
@mahibi
mahibi force-pushed the fixHttp404Exception branch from d1208b2 to fd5a97b Compare September 19, 2026 15:11
Prevents an uncaught HTTP 404 (e.g. note-to-self not available on the
server) from crashing the app when sharing a message to notes.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
mahibi force-pushed the fixHttp404Exception branch from fd5a97b to 8ff6471 Compare September 19, 2026 15:12
@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

馃摫 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit cb8d880
Version 6724
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@mahibi

mahibi commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-25.0.x

@mahibi
mahibi marked this pull request as draft September 19, 2026 15:42
The "Send to Note to Self" action was shown regardless of server
support. Add the `note-to-self` SpreedFeatures capability and require
it in showShareToNote.

Assisted-by: Claude Code:claude-sonnet-5

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
.. in case it will be used somewhere else..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi changed the title fix(chat): catch HttpException/IOException in checkForNoteToSelf fix(chat): guard note to self by capability&avoid crashes Sep 19, 2026
@mahibi
mahibi marked this pull request as ready for review September 19, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant