⚒️🎨 Migrate Profile to Composable

[AndyScherzinger]

• Migrate the activity and scope dialog layouts to composable
• Move away from item adapter to be used for the scope dialog but use MutableList instead

Note: Ultimately but not done by this PR we should move to MVVM - When having/implementing a ProfileViewModel, the item list and updateScope belong there as a StateFlow<List<UserInfoDetailsItem>>. ScopeDialog's onScopeSelected would call viewModel.updateScope(position, scope) and the UI observes the flow. This would be even cleaner but is a larger refactor, making the review more complex. So better do it step by step.

🚧 TODO

• review & merge

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[sowjanyakch]

Edit the profile and rotate the screen. Edited changes are lost - changes must be retained. This needs to be implemented along with MVVM.

[sowjanyakch]

The avatar upload options should be centered aligned.

[AndyScherzinger]

@sowjanyakch regarding center alignment of #5943 (review) for the buttons, if center aligned than they aren't aligned with the profile activation bo x_nor_ with the above user displayname or any other element, so it is very unaligned then, no?

Any feedback @nimishavijay @jancborchardt ?

[nimishavijay]

I would agree that center aligning looks off, I'm wondering if a layout like this is feasible? This removes the center/left aligned issue as the only option is center aligning everything in the left column. In the right column we should make sure to align the icons of the "Enable profile" item with the other icons below

Additionally, if possible we should make the following changes:

• Use a smaller toggle icon for the "Enable profile" toggle
• Reduce its height to the standard height (should be 44px?)
• Remove the background for the "Enable profile" toggle
  What do you think? @AndyScherzinger @sowjanyakch

[AndyScherzinger]

Use a smaller toggle icon for the "Enable profile" toggle

Definitive no on this one. The switch is standard M3/Android.

Reduce its height to the standard height (should be 44px?)

Let's see, list items would be min 56dp but... I did not add it to the list for a reason since all other items are input fields, so
this complicates thing, but let's see. First step could still be to keep it on the left column for easier implementation life.

Remove the background for the "Enable profile" toggle

Sure thing.

[AndyScherzinger]

@nimishavijay @sowjanyakch

[nimishavijay]

Nice! I checked the M3 specs and seems like there is no way to get around it. in that case the priority would be the spacing and alignment

• center align all the icons on the right with the toggle icon
• add some spacing between the text fields and the icons such that there is equal spacing on the left and right of the icons

Once that's done it should be good to go!

[AndyScherzinger]

@nimishavijay final iteration :)

comments fixed

Fixed

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5943.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	98	93
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	54	54
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	81	81